Opened 11 years ago
Closed 11 years ago
#33138 closed defect (bug) (fixed)
Customizer on mobile: fixed grey space at the bottom
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.3 | Priority: | normal |
| Severity: | normal | Version: | 4.3 |
| Component: | Customize | Keywords: | has-patch commit |
| Focuses: | Cc: |
Description
Attachments (5)
Change History (19)
#6
@
11 years ago
- Keywords has-patch added; needs-patch removed
@ celloexpressions, could you review if that patch is in line with what was intended in [33069]?
#7
@
11 years ago
- Keywords needs-patch added; has-patch removed
It's content.css( 'height', ( window.innerHeight - 90 ) ); which needs to be removed/changed for screen sizes below 640px IMO.
#8
@
11 years ago
90 is derived from 45px for the header and 45px for the footer, which is only shown on larger screens. New patch needs to check for screen size < 640px and use 45 instead of 90 in those cases, and should also add inline comments explaining where the magic numbers come from. I've been trying to avoid setting the height in JS like this since panels were first introduced a year ago, but it's just necessary and going to make things easier moving forward to do it this way.
Note: See
TracTickets for help on using
tickets.
Don't remember seeing this in 4.2.