Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#33145 closed defect (bug) (fixed)

Password JS Code Review

Reported by: wonderboymusic Owned by: wonderboymusic
Priority: normal Milestone: 4.3
Component: Users Version: 4.3
Severity: normal Keywords:
Cc: Focuses: javascript, administration

Description

wp-admin/js/user-profile.js needs a look.

Attachments (1)

33145.diff​ (13.4 KB ) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (4)

#1 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Status new → assigned

#2 @wonderboymusic
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 33450:

Passwords UI: clean up the new JS in wp-admin/js/user-profile.js.

Instead of wrapping #pass1 in a <span> dynamically, add the <span> to the HTML in PHP. It currently has no styling.

Fixes #33145.

#3 @adamsilverstein
11 years ago

woot! thanks for your work here @wonderboymusic!

Note: See TracTickets for help on using tickets.