WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#33145 closed defect (bug) (fixed)

Password JS Code Review

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Users Keywords:
Focuses: javascript, administration Cc:

Description

wp-admin/js/user-profile.js needs a look.

Attachments (1)

33145.diff (13.4 KB) - added by wonderboymusic 6 years ago.

Download all attachments as: .zip

Change History (4)

#1 @wonderboymusic
6 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned

@wonderboymusic
6 years ago

#2 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33450:

Passwords UI: clean up the new JS in wp-admin/js/user-profile.js.

Instead of wrapping #pass1 in a <span> dynamically, add the <span> to the HTML in PHP. It currently has no styling.

Fixes #33145.

#3 @adamsilverstein
6 years ago

woot! thanks for your work here @wonderboymusic!

Note: See TracTickets for help on using tickets.