WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#33162 closed defect (bug) (fixed)

Chosen password on installation doesn't persist after form validation error

Reported by: johnbillion Owned by: markjaquith
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Upgrade/Install Keywords: ux-feedback has-patch
Focuses: Cc:

Description

On the installation screen, if the form is submitted with some missing or invalid data (for example, an invalid email address) then the entered password doesn't persist on the next screen a new password is generated.

This happens whether you use the generated password or enter your own.

Ideally the "Hide" state would persist, too.

Attachments (2)

33162.diff (887 bytes) - added by markjaquith 5 years ago.
33162.2.diff (2.5 KB) - added by markjaquith 5 years ago.

Download all attachments as: .zip

Change History (10)

@markjaquith
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Summary changed from Chosen password on installtion doesn't persist after form validation error to Chosen password on installation doesn't persist after form validation error

Related: #26962

#2 follow-up: @markjaquith
5 years ago

  • Summary changed from Chosen password on installation doesn't persist after form validation error to Chosen password on installtion doesn't persist after form validation error

Doesn't persist hidden state, but this at least persists the password.

#3 @markjaquith
5 years ago

  • Summary changed from Chosen password on installtion doesn't persist after form validation error to Chosen password on installation doesn't persist after form validation error

#4 in reply to: ↑ 2 @knutsp
5 years ago

Replying to markjaquith:

Doesn't persist hidden state, but this at least persists the password.

I think it's quite important that the hidden state of the password field is preserved in all cases. If the user click hide then there may be an good reason to do so.

#5 @markjaquith
5 years ago

Hmm. Persisting and then showing might be worse than not persisting, actually. I'm going to say we should fix this with persistence of the hidden state, or we should punt it altogether.

(It would also be nice if some basic form validation was done in JS, like making sure your e-mail address conforms to X@… at a bare minimum).

@markjaquith
5 years ago

#6 @markjaquith
5 years ago

  • Keywords has-patch added; needs-patch removed

33162.2.diff fixes the issue by defaulting the password to hidden when a password has been passed in. Simpler than recording whether the user clicked the button.

#7 @obenland
5 years ago

  • Owner set to markjaquith
  • Status changed from new to assigned

#8 @markjaquith
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33495:

Persist (and mask) the password on the install screen if the install does not proceed due to errors.

If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.

fixes #33162

Note: See TracTickets for help on using tickets.