Chosen password on installation doesn't persist after form validation error

[johnbillion]

On the installation screen, if the form is submitted with some missing or invalid data (for example, an invalid email address) then the entered password doesn't persist on the next screen a new password is generated.

This happens whether you use the generated password or enter your own.

Ideally the "Hide" state would persist, too.

[SergeyBiryukov]

Related: #26962

[markjaquith]

Doesn't persist hidden state, but this at least persists the password.

[knutsp]

Replying to markjaquith:

Doesn't persist hidden state, but this at least persists the password.

I think it's quite important that the hidden state of the password field is preserved in all cases. If the user click hide then there may be an good reason to do so.

[markjaquith]

Hmm. Persisting and then showing might be worse than not persisting, actually. I'm going to say we should fix this with persistence of the hidden state, or we should punt it altogether.

(It would also be nice if some basic form validation was done in JS, like making sure your e-mail address conforms to X@… at a bare minimum).

[markjaquith]

33162.2.diff​ fixes the issue by defaulting the password to hidden when a password has been passed in. Simpler than recording whether the user clicked the button.

[markjaquith]

In 33495:

Persist (and mask) the password on the install screen if the install does not proceed due to errors.

If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.

fixes #33162