New password UI on user profile - hide button shows wrong state

[knutsp]

Steps to reproduce in profile.php:

1. Click "Generate password"
2. Click "Hide" (the important step here)
3. Click "Cancel"
4. Click "Generate password" (again)

Expected, either

1. Password is hidden and button says "Show"
2. Password is shown and button says "Hide"

Actual:

• Password is shown and button says "Show"
• When clicking "Show" nothing happens (at this time expected, though)

Conclusion: When "Cancel" is activated the state of both the password field and the show/hide button should be preserved, or both should return to their default states.

4.3-beta4-33468

[knutsp]

After some thought: I would absolutely prefer the "hidden" state to persist and not returning to the default state (showing).

[markjaquith]

In 33475:

Do not re-generate the password after pressing "cancel". Persist the state.

Also removes pass2 code not needed since we're generating from one field.

fixes #33164