Opened 11 years ago
Closed 11 years ago
#33176 closed defect (bug) (fixed)
Customizer Menus: Duplicate item in Menu Location selection
| Reported by: | tywayne | Owned by: | westonruter |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.3 |
| Component: | Customize | Version: | 4.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | javascript |
Description
Steps to reproduce:
- Create a new menu in customizer
- Save and Publish
- Navigate to Menu Locations
- Opening <select> shows duplicate
gif of steps here: https://cloudup.com/c0NgUy11GdP
The duplicate item in menu location <select> has a temp id, so most likely not being correctly replaced on save.
Attachments (1)
Change History (7)
#3
follow-up:
↓ 5
@
11 years ago
- Keywords has-patch added; needs-patch removed
@tywayne: Good catch! So this is an amendment to #32814.
Please test 33176.diff. It updates the nav_menu_locations controls to remove the placeholder menu option when the menu is inserted.
This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.
11 years ago
#5
in reply to: ↑ 3
@
11 years ago
Replying to westonruter:
@tywayne: Good catch! So this is an amendment to #32814.
Please test 33176.diff. It updates the
nav_menu_locationscontrols to remove the placeholder menu option when the menu is inserted.
Looks good to me. Working as expected now, thanks!
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
https://github.com/xwp/wordpress-develop/pull/109