WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#33176 closed defect (bug) (fixed)

Customizer Menus: Duplicate item in Menu Location selection

Reported by: tywayne Owned by: westonruter
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description

Steps to reproduce:

  1. Create a new menu in customizer
  2. Save and Publish
  3. Navigate to Menu Locations
  4. Opening <select> shows duplicate

gif of steps here: https://cloudup.com/c0NgUy11GdP

The duplicate item in menu location <select> has a temp id, so most likely not being correctly replaced on save.

Attachments (1)

33176.diff (1.2 KB) - added by westonruter 5 years ago.
https://github.com/xwp/wordpress-develop/pull/109

Download all attachments as: .zip

Change History (7)

#1 @obenland
5 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to westonruter
  • Status changed from new to assigned

#2 @westonruter
5 years ago

  • Focuses javascript added
  • Keywords needs-patch added
  • Status changed from assigned to accepted

#3 follow-up: @westonruter
5 years ago

  • Keywords has-patch added; needs-patch removed

@tywayne: Good catch! So this is an amendment to #32814.

Please test 33176.diff. It updates the nav_menu_locations controls to remove the placeholder menu option when the menu is inserted.

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


5 years ago

#5 in reply to: ↑ 3 @tywayne
5 years ago

Replying to westonruter:

@tywayne: Good catch! So this is an amendment to #32814.

Please test 33176.diff. It updates the nav_menu_locations controls to remove the placeholder menu option when the menu is inserted.

Looks good to me. Working as expected now, thanks!

#6 @westonruter
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33496:

Customizer: Update nav_menu_locations[...] controls to remove placeholder menus from the dropdown options upon Save & Publish.

See #32814.
Fixes #33176.

Note: See TracTickets for help on using tickets.