WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33178 closed defect (bug) (fixed)

Legacy theme preview no longer works when using a static front page

Reported by: helen Owned by: ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

We kept the old theme preview for no-JS and some browsers that are less capable (no postMessage I think?), but upon testing no-JS on the themes screen recently, the link no longer works for me when using a static front page. The link looks like http://example.com/?preview=1&template=twentythirteen&stylesheet=twentythirteen&preview_iframe=1&TB_iframe=1. It does work otherwise, like on single posts or with posts on front, but since preview links to the home, that's not very helpful for a pretty significant number of sites. I haven't taken the time to look into what's going wrong and did not see any existing tickets. It doesn't seem particularly critical to me to keep theme previewing for these narrow situations, and I think it's a chance to lose dead code.

Would need to write this up on Make/Core, as it is essentially impossible to detect plugin usage in this instance.

Attachments (1)

33178.patch (15.3 KB) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
4 years ago

#1 @ocean90
4 years ago

  • Keywords has-patch added

I agree, there is no need to to enhance pre-3.5 stuff.

#2 @ocean90
4 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 33492:

Themes: Remove legacy theme preview.

The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

#3 @ocean90
4 years ago

In 33519:

Fix PHP notice after [33492].

props jesin.
see #33178.
fixes #33208.

Note: See TracTickets for help on using tickets.