Legacy theme preview no longer works when using a static front page

[helen]

We kept the old theme preview for no-JS and some browsers that are less capable (no postMessage I think?), but upon testing no-JS on the themes screen recently, the link no longer works for me when using a static front page. The link looks like http://example.com/?preview=1&template=twentythirteen&stylesheet=twentythirteen&preview_iframe=1&TB_iframe=1. It does work otherwise, like on single posts or with posts on front, but since preview links to the home, that's not very helpful for a pretty significant number of sites. I haven't taken the time to look into what's going wrong and did not see any existing tickets. It doesn't seem particularly critical to me to keep theme previewing for these narrow situations, and I think it's a chance to lose dead code.

Would need to write this up on Make/Core, as it is essentially impossible to detect plugin usage in this instance.

[ocean90]

I agree, there is no need to to enhance pre-3.5 stuff.

[ocean90]

In 33492:

Themes: Remove legacy theme preview.

The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!

fixes #33178.

[ocean90]

In 33519:

Fix PHP notice after [33492].

props jesin.
see #33178.
fixes #33208.