Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33182 closed defect (bug) (fixed)

Customizer: remove redundant aria-label

Reported by: afercia's profile afercia Owned by: westonruter's profile westonruter
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch dev-feedback commit
Focuses: ui, accessibility Cc:


Looks like this aria-label is no more necessary:

that div is no more focusable, there's no way screen readers can read out its aria-label, unless I'm missing something. Maybe a leftover from 4.2 when it was focusable and used to display the section description when clicked.

Attachments (2)

33182.patch (890 bytes) - added by afercia 9 years ago.
33182.2.diff (3.2 KB) - added by westonruter 9 years ago.
Additional change:

Download all attachments as: .zip

Change History (12)

9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Customizer: remove no more necessary aria-label attribute from main section title

#2 @westonruter
9 years ago

  • Milestone changed from Awaiting Review to Future Release

#3 @afercia
9 years ago

One more unnecessary aria-label attribute (and tabindex):

This one comes from render_screen_options() in screen.php. Reusing things is a good thing of course but both the aria-label and tabindex attribute used in render_screen_options() are strictly tied to the expandable panels used in the main admin screens and here in the Customizer are unnecessary. Open to suggestions :)

#4 @westonruter
9 years ago

  • Milestone changed from Future Release to 4.4

@afercia Take a look at 33182.2.diff. It introduces an option to render_screen_options() to disable the wrap element. The option is true by default, but in the Customizer we can set it to false and supply our own wrapper.

#5 @afercia
9 years ago

@westonruter: makes sense to me :)

Side note: testing the Screen Options and Help panels, looks like NVDA and JAWS don't read out the panels aria-label attributes, respectively: "Screen Options Tab" and "Contextual Help Tab". Only ChromeVox does. I think they would need some ARIA roles. Also, wondering if they're really useful. By the way this is out of the scope of this ticket. Planning to do some more testing and maybe open a new ticket, looks like this is an admin area where there's room for improvements, see #21583 and the original accessibility related ticket #21326.

In the screenshot below: the aria-label doesn't get announced (NVDA)

#6 follow-up: @westonruter
9 years ago

  • Keywords dev-feedback added

@wonerboymusic: Any concerns with 33182.2.diff which adds an $options argument to WP_Screen:: render_screen_options ()?

#7 in reply to: ↑ 6 @afercia
9 years ago

Replying to westonruter:

@wonerboymusic: Any concerns with 33182.2.diff which adds an $options argument to WP_Screen:: render_screen_options ()?

@wonderboymusic ! just to trigger the notification :)

This ticket was mentioned in Slack in #core by sergey. View the logs.

9 years ago

#9 @SergeyBiryukov
9 years ago

  • Keywords commit added
  • Owner set to westonruter
  • Status changed from new to assigned

#10 @westonruter
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34093:

Customize: Remove redundant aria-label attributes.

Adds an $options array argument to WP_Screen::render_screen_options() to allow the div#screen-options-wrap element to be omitted when wrap value is false.

Props afercia, westonruter.
Fixes #33182.

Note: See TracTickets for help on using tickets.