WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#33183 closed defect (bug) (fixed)

Similar Customizing strings

Reported by: pavelevap Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

Do we need all these strings?

Customizing
Customizing ▸ %s
Customizing ▸ Menus
You are customizing %s

Why "Menus" has its own string when "Widgets" uses general placeholder "%s"? Also "Customizing" is mostly used wrong, because there are following words and it could be changed to "Customizing %s"? Why "Customizing" and "You are customizing" strings?

They are mostly duplicates or I am missing something? In the end there could be only one or two strings?

Customizing %s
Customizing ▸ %s

Attachments (1)

33183.diff (1.0 KB) - added by obenland 5 years ago.

Download all attachments as: .zip

Change History (6)

#1 @obenland
5 years ago

  • Milestone changed from Awaiting Review to 4.3

Customizing ▸ Menus can be changed to use Customizing ▸ %s.
You are customizing %s is used on index as well as Panels, I don't mind keeping that around for both those use cases.
We can't switch Customize to Customize %s since we have nothing to replace that placeholder with at the time of translation.

#2 @obenland
5 years ago

  • Keywords has-patch added
  • Owner set to obenland
  • Status changed from new to accepted

#3 @ocean90
5 years ago

  • Keywords commit added

33183.diff looks good. The others shouldn't be changed.

@obenland
5 years ago

#4 @westonruter
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33493:

Customizer: Remove redundant translated string.

Props obenland.
Fixes #33183.

#5 @pavelevap
5 years ago

Thank you!

I thought about merging "Customizing" and "You are customizing" strings, because I do not see a reason why there is "Customizing Site Identity", "You are customizing Menu", etc?

I do not understand why it is not possible to switch from Customizing to Customizing %s? But I am not very familiar with Customizer code :-) I found that for Customizing ▸ %s is used $this->manager->get_panel( $this->panel )->title, maybe it could work also for Customizing %s with placeholder?

Note: See TracTickets for help on using tickets.