WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33207 closed enhancement (fixed)

Add ReverbNation to the internal whitelist of oembed providers

Reported by: rhubbardreverb Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Embeds Keywords:
Focuses: Cc:
PR Number:

Description

This patch simply adds ReverbNation to the internal whitelist of oembed providers to allow for easy embedding of ReverbNation artists and songs.

Examples:

https://www.reverbnation.com/oembed?url=https%3A%2F%2Fwww.reverbnation.com%2Fcoralbones
https://www.reverbnation.com/oembed?url=https%3A%2F%2Fwww.reverbnation.com%2Fcoralbones%2Fsong%2F18668300-rising-sand

About ReverbNation:

Since 2006, ReverbNation has helped millions of emerging Artists build their careers. We’ve connected Artists to venues, festivals, brands, publishers, labels, and the fans themselves. ReverbNation’s mission puts Artists First.

We have over 4 million artists with over 14 million songs looking to share their content on Wordpress.

Robert Hubbard
CTO ReverbNation

Attachments (1)

wordpress.patch (1.1 KB) - added by rhubbardreverb 4 years ago.
Patch of change

Download all attachments as: .zip

Change History (13)

@rhubbardreverb
4 years ago

Patch of change

#1 follow-ups: @ocean90
4 years ago

Hello rhubbardreverb, can you please answer the questions from this list http://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers? Thank you!

#2 in reply to: ↑ 1 @rhubbardreverb
4 years ago

Replying to ocean90:

Hello rhubbardreverb, can you please answer the questions from this list http://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers? Thank you!

Is the service is popular enough for core developers to have heard of it before?

We are well-known among musicians. Over 4 million verified artists have registered on our site.

If similar services are already supported, how does this service compare in terms of size, features, and backing?

The embed being provided is a music player for streaming content from our artists. Similar to SoundCloud, Rdio, Spotify.

Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?

https://www.facebook.com/ReverbNation 1.2 million likes
https://twitter.com/ReverbNation 300K followers

Is its oEmbed endpoint clearly established and properly documented?

Not documented as of yet. I will see this gets done.

Does the service make an effort to build relationships with developers, such as through robust APIs?

We do not currently offer any public APIs.

How old is the service?

ReverbNation has been around since 2006. We have over 80 employees with offices in Durham, NC and New York, NY.

Does it have a well-established Wikipedia article?

https://en.wikipedia.org/wiki/ReverbNation

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

https://wordpress.org/plugins/reverbnation-master/

Not from us.

Is the provider frequently proposed?

No idea

Last edited 4 years ago by rhubbardreverb (previous) (diff)

#3 in reply to: ↑ 1 @rhubbardreverb
4 years ago

Replying to ocean90:

Hello rhubbardreverb, can you please answer the questions from this list http://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers? Thank you!

A follow up:

We have recently documented our oEmbed support at:

https://www.reverbnation.com/developers/oembed

Also we a registered provider at http://oembed.com/. And we have been whitelisted at http://wordpress.com/,

Example:

https://rreverb.wordpress.com/

And here is an example of our new HTML5 player (not released yet):

https://www.reverbnation.com/sampleband?popup_render=page_object%2Fshare_song%2F6921

Please let me know if there is anything else I can provide to help expedite oEmbed support for Reverbnation.com.

Robert Hubbard
CTO ReverbNation

#4 @pento
4 years ago

  • Keywords 4.4-early added
  • Milestone changed from Awaiting Review to Future Release
  • Version trunk deleted

Thank you for the extra documentation and example, @rhubbardreverb!

We're too late to make the upcoming 4.3 release, but I'm cool with this going into 4.4.

#5 @rhubbardreverb
4 years ago

OK, thanks Gary.

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 4.4

#7 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33745:

Add oEmbed support for ReverbNation.

props rhubbardreverb.
fixes #33207.

#8 follow-up: @johnbillion
4 years ago

  • Keywords reporter-feedback added; 4.4-early removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

@rhubbardreverb I'm working a suite of unit tests for our oEmbed providers (see #32360) and it's highlighted the fact that the response from the Reverbnation oEmbed endpoint is not valid. Can you ask your team to take a look at the following please?

  • The version field in the response has a value of 1.1. There is no such thing as version 1.1 of the oEmbed specification.
  • The provider-name, provider-url, author-name, author-url, and thumbnail-url fields are all incorrectly named, as their names should contain underscores not dashes. I suspect this is deliberate, and the reason why the endpoint is claiming to be oEmbed version 1.1, but inventing a specification benefits nobody.

WordPress core doesn't currently use these fields, but oEmbed plugins often do, and core may well do in the future.

Let me know when you've taken a look!

#9 @johnbillion
4 years ago

  • Owner changed from SergeyBiryukov to johnbillion
  • Status changed from reopened to reviewing

#10 in reply to: ↑ 8 ; follow-up: @rhubbardreverb
4 years ago

@johnbillion - OK, we have changed the version back to 1.0. This should go up with this afternoon deploy by 5pm today (8/31/15).

-Robert

Replying to johnbillion:

@rhubbardreverb I'm working a suite of unit tests for our oEmbed providers (see #32360) and it's highlighted the fact that the response from the Reverbnation oEmbed endpoint is not valid. Can you ask your team to take a look at the following please?

  • The version field in the response has a value of 1.1. There is no such thing as version 1.1 of the oEmbed specification.
  • The provider-name, provider-url, author-name, author-url, and thumbnail-url fields are all incorrectly named, as their names should contain underscores not dashes. I suspect this is deliberate, and the reason why the endpoint is claiming to be oEmbed version 1.1, but inventing a specification benefits nobody.

WordPress core doesn't currently use these fields, but oEmbed plugins often do, and core may well do in the future.

Let me know when you've taken a look!

#11 in reply to: ↑ 10 @rhubbardreverb
4 years ago

This is now live:

https://www.reverbnation.com/oembed?url=https%3A%2F%2Fwww.reverbnation.com%2Fcoralbones

Thanks,
Robert

Replying to rhubbardreverb:

@johnbillion - OK, we have changed the version back to 1.0. This should go up with this afternoon deploy by 5pm today (8/31/15).

-Robert

Replying to johnbillion:

@rhubbardreverb I'm working a suite of unit tests for our oEmbed providers (see #32360) and it's highlighted the fact that the response from the Reverbnation oEmbed endpoint is not valid. Can you ask your team to take a look at the following please?

  • The version field in the response has a value of 1.1. There is no such thing as version 1.1 of the oEmbed specification.
  • The provider-name, provider-url, author-name, author-url, and thumbnail-url fields are all incorrectly named, as their names should contain underscores not dashes. I suspect this is deliberate, and the reason why the endpoint is claiming to be oEmbed version 1.1, but inventing a specification benefits nobody.

WordPress core doesn't currently use these fields, but oEmbed plugins often do, and core may well do in the future.

Let me know when you've taken a look!

#12 @johnbillion
4 years ago

  • Keywords reporter-feedback removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

Thanks!

Note: See TracTickets for help on using tickets.