WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#33208 closed defect (bug) (fixed)

Undefined index notice after installing a theme

Reported by: jesin Owned by: ocean90
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: Upgrade/Install Keywords: commit has-patch
Focuses: Cc:

Description

After a theme installed either from the WP.org repo or file upload the following notice is displayed:

 Notice: Undefined index: preview in /var/www/wptrunk/src/wp-admin/includes/class-wp-upgrader-skins.php on line 663

The bug was introduced in 33492 when $install_actions['preview'] =[...] was removed at line 667. The current line 663 has a concatenating assignment operator (.=) which is causing this notice.

Attachments (1)

33208.diff (1.2 KB) - added by jesin 6 years ago.

Download all attachments as: .zip

Change History (6)

@jesin
6 years ago

#1 @helen
6 years ago

  • Keywords commit added

#2 @helen
6 years ago

  • Component changed from Administration to Upgrade/Install
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.3

#3 @ocean90
6 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 33519:

Fix PHP notice after [33492].

props jesin.
see #33178.
fixes #33208.

#4 @bobbingwide
6 years ago

I'll need to check but I've just got this after upgrading to 4.3
and applying a theme update to Genesis 2.1.3

Notice: Undefined index: preview in /nas/wp/www/cluster-41759/vsgloik/wp-admin/includes/class-wp-upgrader-skins.php on line 742

Version 0, edited 6 years ago by bobbingwide (next)

#5 @dd32
6 years ago

In 33645:

Fix PHP notice after [33492] when updating themes.

Props bobbingwide.
See #33208.
Fixes #33427.

Note: See TracTickets for help on using tickets.