Opened 9 years ago
Closed 9 years ago
#33212 closed defect (bug) (fixed)
Add some more space to german and norwegian (bokmål) quick edit labels
Reported by: | Clorith | Owned by: | helen |
---|---|---|---|
Milestone: | 4.3 | Priority: | low |
Severity: | trivial | Version: | 4.3 |
Component: | Quick/Bulk Edit | Keywords: | has-patch commit dev-reviewed |
Focuses: | ui | Cc: |
Description
German (formal) does not align properly in the 4.3 trunk when using quick edit.
Attached patch fixes this, and also fixes the Norwegian (Bokmål) issue for the same area.
Attachments (14)
Change History (38)
#2
@
9 years ago
- Component changed from General to Quick/Bulk Edit
- Milestone changed from Awaiting Review to 4.3
- Summary changed from Add some more space to german (formal) and norwegina (bokmål) quick edit labels to Add some more space to german (formal) and norwegian (bokmål) quick edit labels
#3
@
9 years ago
- Summary changed from Add some more space to german (formal) and norwegian (bokmål) quick edit labels to Add some more space to german and norwegian (bokmål) quick edit labels
It's needed for both variants of German.
Before and after screenshots would be great.
#4
@
9 years ago
Screenshots of what?
I just figured that it looks all fine in 4.2.3 in (normal) german, formal german und swiss german (which is just different in die ß (german esszet) vs the swiss version uses 'ss').
And now in 4.3 RC1 normal and formal german is out of the grid.
And swiss german has now the english date format, meaning month dropdown before the day input field.
#5
@
9 years ago
Original report here has a before screenshot: https://wordpress.org/support/topic/posts-quickedit-date-in-formal-and-normal-german-out-of-design-grid
#6
@
9 years ago
- Priority changed from normal to low
- Severity changed from normal to trivial
- Type changed from enhancement to defect (bug)
33212.2.patch is 33212.patch plus the same fix for ru_RU and resets the left margin for narrow screens. Before/after screenshots attached.
#10
@
9 years ago
This is made to fit exactly for English... As soon as "Password" is a character longer it wraps.
#11
@
9 years ago
Introduced in [32945], which changed the Date field from <label>
to <legend>
.
33212.2.patch does not fix the issue for me:
- The width should be set for
span.title
, not forlegend
. .timestamp-wrap
needs to be adjusted in the same way asspan.input-text-wrap
.
See 33212.3.patch.
#12
follow-up:
↓ 13
@
9 years ago
33212.3.patch breaks .timestamp-wrap
for other languages, see https://cloudup.com/cmc0a1TC3gm. Fixed in 33212.4.patch.
33212.4.patch changes the default value to 6em
and removes the extra styles for de_DE, de_DE_formal, and ru_RU. lt_LT is still needed because their translation of "slug" is "Nuoroda (slug)".
#13
in reply to:
↑ 12
;
follow-up:
↓ 15
@
9 years ago
Replying to ocean90:
33212.4.patch changes the default value to
6em
and removes the extra styles for de_DE, de_DE_formal, and ru_RU.
6em
is not enough for ru_RU, see 33212-bulk-edit-ru_RU.png.
7em
would work.
#14
@
9 years ago
Nice, 33212.4.patch fixes also cs_CZ (long "Slug" label translation).
"Date" label in mobile view should be above fields (as all other fields)?
#15
in reply to:
↑ 13
@
9 years ago
Replying to SergeyBiryukov:
6em
is not enough for ru_RU, see 33212-bulk-edit-ru_RU.png.
7em
would work.
That's the reason why we should always add screenshots for visual changes. Your screenshot is from Quick Edit for pages which has different/longer labels. I'm fine with adding 7em for ru_RU again.
#16
@
9 years ago
- Keywords needs-refresh added
@SergeyBiryukov would you mind updating the patch? It would be nice to have that fixed in RC2.
This ticket was mentioned in Slack in #core by obenland. View the logs.
9 years ago
#20
@
9 years ago
- Keywords has-patch added; needs-patch removed
33212.7.patch works in Firefox (comment:19] and fixes responsiveness (comment:14).
#21
@
9 years ago
- Keywords commit added
33212.7.patch looks good.
In 33212.3.patch I changed the selector for consistency with label span.title
, but it doesn't seem worth it.
Previously: #25753