Add some more space to german and norwegian (bokmål) quick edit labels

[Clorith]

German (formal) does not align properly in the 4.3 trunk when using quick edit.

Attached patch fixes this, and also fixes the Norwegian (Bokmål) issue for the same area.

[SergeyBiryukov]

Previously: #25753

[ocean90]

It's needed for both variants of German.
Before and after screenshots would be great.

[transl8or]

Screenshots of what?
I just figured that it looks all fine in 4.2.3 in (normal) german, formal german und swiss german (which is just different in die ß (german esszet) vs the swiss version uses 'ss').

And now in 4.3 RC1 normal and formal german is out of the grid.
And swiss german has now the english date format, meaning month dropdown before the day input field.

[johnbillion]

Original report here has a before screenshot: ​https://wordpress.org/support/topic/posts-quickedit-date-in-formal-and-normal-german-out-of-design-grid

[ocean90]

33212.2.patch​ is 33212.1.patch plus the same fix for ru_RU and resets the left margin for narrow screens. Before/after screenshots attached.

[iseulde]

This is needed for Dutch too.

[ocean90]

Should we improve the default value? Maybe 6 or 6.5em?

[iseulde]

@ocean90 Probably the sanest solution. :)

[iseulde]

This is made to fit exactly for English... As soon as "Password" is a character longer it wraps.

[SergeyBiryukov]

Introduced in [32945], which changed the Date field from <label> to <legend>.

33212.2.patch​ does not fix the issue for me:

• The width should be set for span.title, not for legend.
• .timestamp-wrap needs to be adjusted in the same way as span.input-text-wrap.

See 33212.3.patch​.

[ocean90]

33212.3.patch​ breaks .timestamp-wrap for other languages, see ​https://cloudup.com/cmc0a1TC3gm. Fixed in 33212.4.patch​.

33212.4.patch​ changes the default value to 6em and removes the extra styles for de_DE, de_DE_formal, and ru_RU. lt_LT is still needed because their translation of "slug" is "Nuoroda (slug)".

[SergeyBiryukov]

Replying to ocean90:

33212.4.patch​ changes the default value to 6em and removes the extra styles for de_DE, de_DE_formal, and ru_RU.

6em is not enough for ru_RU, see 33212-bulk-edit-ru_RU.png​.

7em would work.

[pavelevap]

Nice, 33212.4.patch fixes also cs_CZ (long "Slug" label translation).

"Date" label in mobile view should be above fields (as all other fields)?

[ocean90]

Replying to SergeyBiryukov:

6em is not enough for ru_RU, see 33212-bulk-edit-ru_RU.png​.

7em would work.

That's the reason why we should always add screenshots for visual changes. Your screenshot is from Quick Edit for pages which has different/longer labels. I'm fine with adding 7em for ru_RU again.

[obenland]

@SergeyBiryukov would you mind updating the patch? It would be nice to have that fixed in RC2.

[ocean90]

I already had 33212.5.patch​ on my disk.

[helen]

Patch breaks "Date" label.

[ocean90]

33212.7.patch​ works in Firefox (comment:19] and fixes responsiveness (comment:14).

[SergeyBiryukov]

33212.7.patch​ looks good.

In 33212.3.patch​ I changed the selector for consistency with label span.title, but it doesn't seem worth it.

[nacin]

Looks good to me.

[ocean90]

In 33598:

List tables: Adjust width of Quick Edit labels for longer translations.

props Clorith, SergeyBiryukov, ocean90.
fixes #33212.