WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33229 closed defect (bug) (fixed)

Customizer: remove the no more used "control-panel-back"

Reported by: afercia's profile afercia Owned by: ocean90's profile ocean90
Milestone: 4.3 Priority: low
Severity: minor Version: 4.3
Component: Customize Keywords: has-patch commit dev-reviewed
Focuses: ui, accessibility, javascript Cc:

Description

The .control-panel-back UI control, for clarity the one I've made temporary visible in the screenshot below:

https://cldup.com/aDOw240Sem.png

seems to always be offset -48px and never comes into view. ​Asked on slack and it appears to be a leftover from #31336.

Should be removed together with any related JavaScript and CSS, not just for cleaning up but also because screen readers may announce "Back" when arrowing around there.

Attachments (2)

33229.patch​ (3.2 KB) - added by afercia 9 years ago.
33229.2.patch​ (6.2 KB) - added by ocean90 9 years ago.

Download all attachments as: .zip

Change History (12)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Customizer: remove no more used UI control .control-panel-back

This ticket was mentioned in ​Slack in #core by obenland. ​View the logs.
9 years ago

#3 @obenland
9 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to ocean90
  • Status changed from new to assigned

@ocean90
9 years ago

#4 @ocean90
9 years ago

We can remove .customize-overlay-close as well. It was a workaround for ticket:28784:44.

#5 @ocean90
9 years ago

  • Keywords commit added

#6 @obenland
9 years ago

@ocean90, are you ready to pull the trigger on this?

#7 follow-up: @ocean90
9 years ago

  • Priority changed from normal to low
  • Severity changed from normal to minor

@helen, @azaozz: Can one of you take a quick look at this please?

#8 in reply to: ↑ 7 @mrahmadawais
9 years ago

Replying to ocean90:

@helen, @azaozz: Can one of you take a quick look at this please?

Tested it, seemed fine!

Version 0, edited 9 years ago by mrahmadawais (next)

#9 @nacin
9 years ago

  • Keywords dev-reviewed added

Looks good.

#10 @ocean90
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33599:

Customizer: Remove obsolete .control-panel-back and .customize-overlay-close buttons.

props afercia, ocean90.
see #31336.
fixes #33229.

Note: See TracTickets for help on using tickets.