Invalid file type - similar strings

[pavelevap]

We have 3 very similar strings which are used for same error:

Invalid file type
This file type is not allowed. Please try another.
Sorry, this file type is not permitted for security reasons.

I do not see any reason why we should preserve them all? I can create patch, but I am not sure which one is the best? Maybe some simple combination like "Sorry, this file type is not allowed."?

[swissspidy]

All three strings are used in different contexts:

• Invalid file type is used as an error message in wp_upload_bits
• This file type is not allowed. Please try another. is used as an error message for the flash uploader. Most error messages there have the Please try another. ending.
• Sorry, this file type is not permitted for security reasons. is used in _wp_handle_upload

At best merging strings 1 and 3 would make sense in my opinion.

[pavelevap]

Yes, different functions, but users should know the same thing for all cases: "This file type is not allowed". I do not see a reason to tell them that it can be "invalid", "not allowed" or "not permitted".

I would ignore "Please try another" part, because it is not exact. Another what? Filetype or file?

"Sorry, this file type is not allowed to upload." or something similar could be enough for all cases.

[jackreichert]

Proposed language change implementation.

[SergeyBiryukov]

In 39891:

Media: Use a consistent error message for file type errors on uploading.

Props pavelevap, jackreichert.
Fixes #33242.