4.3 - Invalid arguments passed to wp_validate_redirect within wp_safe_redirect()

[paultgoodchild]

File: pluggable.php
Line: 1284
Function: wp_safe_redirect()

Current/Bug:

$location = wp_validate_redirect( $location, apply_filters( 'wp_safe_redirect_fallback', admin_url(), $status ) );

Fix:

$location = wp_validate_redirect( $location, apply_filters( 'wp_safe_redirect_fallback', admin_url() ), $status );

Reasoning:
The $status is being passed to the new 'wp_safe_redirect_fallback' filter as the 3rd parameter (which doesn't exist). It should be passed to wp_validate_redirect() as its 2nd parameter

[obenland]

Hi Paul, thanks for bring this up!

Hook callbacks, no matter whether they are action or filter callbacks, will get all arguments passed on to them that are defined after the name of the hook (in this case wp_safe_redirect_fallback). So the only arguments it gets is admin_url() and $status.

From the function documentation of apply_filters():

 * @param string $tag   The name of the filter hook.
 * @param mixed  $value The value on which the filters hooked to `$tag` are applied on.
 * @param mixed  $var   Additional variables passed to the functions hooked to `$tag`.
 * @return mixed The filtered value after all hooked functions are applied to it.

[paultgoodchild]

Ahh yes, my bad. I see exactly what you mean!