Inconsistent KSES Shortcode Result

[miqrogroove]

In shortcodes.php,

if ( '' !== $new_attr ) {

should be

if ( '' !== trim( $new_attr ) ) {

Otherwise we get two different results depending on how much whitespace surrounds an attribute that contained a shortcode.

[Ankit K Gupta]

added patch file

[Ankit K Gupta]

Updated the code as per miqrogroove suggestion.

[obenland]

Added unit test. Not sure if that is enough though.

[miqrogroove]

Replying to obenland:

Added unit test. Not sure if that is enough though.

Not quite, but it's always good to have extra tests. I'll get this out tonight.

[miqrogroove]

The added test passes only after patch.

[ocean90]

33259.2.diff​ works for me.

Without the change to trim( $new_attr ) the test fails with

1) Tests_Shortcode::test_escaping with data set #2 ('1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >', '1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1 <a noise="[test-shortcode-tag]"> 2 <a noise=" [test-shortcode-tag] " >'
+'1 <a noise="[test-shortcode-tag]"> 2 <a  >'

/srv/www/wp-develop/svn/tests/phpunit/tests/shortcode.php:412

[SergeyBiryukov]

33259.2.diff​ looks good.

[nacin]

Looks good. No issues removing a null byte, right?

[miqrogroove]

wp_kses_one_attr() is going to strip nulls first. This patch will never see or touch nulls.

[ocean90]

In 33600:

Shortcodes: Trim whitespace after sanitizing the shortcode output.

props Ankit K Gupta, obenland, miqrogroove.
fixes #33259.