WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#33286 closed defect (bug) (fixed)

inline toolbar: make sure repositioning doesn't break for inline editors

Reported by: iseulde Owned by: iseulde
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.3
Component: TinyMCE Keywords: has-patch commit
Focuses: Cc:

Description

If the editor is inline, mceIframe will be null.

Attachments (3)

33286.patch (845 bytes) - added by iseulde 6 years ago.
33286.2.patch (1.5 KB) - added by iseulde 6 years ago.
33286.3.patch (1.5 KB) - added by iseulde 6 years ago.

Download all attachments as: .zip

Change History (10)

@iseulde
6 years ago

#1 @iseulde
6 years ago

  • Keywords has-patch added

Patch does not change anything for normal editors.

#2 @obenland
6 years ago

  • Owner set to iseulde
  • Status changed from new to assigned
  • Version set to trunk

This ticket was mentioned in Slack in #core by iseulde. View the logs.


6 years ago

@iseulde
6 years ago

#4 @iseulde
6 years ago

Okay, so how to test this patch?

Go to post(-new).php and open the help tab. In the console, run tinyMCE.init({selector:'#tab-panel-customize-display',inline:1,plugins:'wordpress,wplink'}). Now the help text you see will be editable. Create a link and put the cursor in it. Without the patch there will be an error. With the patch the toolbar will show up, correctly positioned. Please also test the main editor and maybe other editor instances.

@iseulde
6 years ago

#5 @azaozz
6 years ago

  • Keywords commit added

33286.3.patch looks good.

#6 @ocean90
6 years ago

33286.3.patch tested in current Chrome, Firefox and IE 8 with the steps in comment:4. Broken before, works with patch applied.

#7 @iseulde
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33592:

TinyMCE: fix inline toolbar repositioning for inline editors

Fixes #33286.

Note: See TracTickets for help on using tickets.