WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#33289 closed task (blessed) (fixed)

Remove existing Internal Pointers

Reported by: obenland Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

As discussed in yesterday's dev chat, let's remove all existing pointers and not add new ones for 4.3.

Attachments (1)

33289.diff (3.9 KB) - added by obenland 6 years ago.

Download all attachments as: .zip

Change History (9)

@obenland
6 years ago

#1 @obenland
6 years ago

33289.diff removes all existing pointers. I commented out parts of it to have an easy reminder on how it should look like when adding new ones in the future.

#2 @obenland
6 years ago

  • Type changed from defect (bug) to task (blessed)

This ticket was mentioned in Slack in #core by obenland. View the logs.


6 years ago

#4 @obenland
6 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#5 follow-up: @ocean90
6 years ago

33289.diff looks good.

Instead of commenting out parts what about

$registered_pointers = array(
    // hook suffix => pointer callback
);

$caps_required = array(
    // pointer callback => Array of required capabilities
);

#6 in reply to: ↑ 5 @obenland
6 years ago

Replying to ocean90:

Instead of commenting out parts what about

$registered_pointers = array(
    // hook suffix => pointer callback
);

$caps_required = array(
    // pointer callback => Array of required capabilities
);

Sure, works for me.

#7 @SergeyBiryukov
6 years ago

33289.diff looks good to me.

We could add the comments suggested in comment:5, but I would also keep one of the current lines as an example (as the patch does).

#8 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33593:

Remove all existing internal feature pointers.

Fixes #33289
Props obenland, ocean90, SergeyBiryukov

Note: See TracTickets for help on using tickets.