Editor: Editing the URL of an image in visual editor removes the image.

[obenland]

Using the visual editor: if you edit the URL of an image with the "Link" tool in the TinyMCE toolbar, the image is removed and the plain URL is displayed instead.

Screen cast to show the issue - ​​http://quick.as/4n4zcbxqb

To reproduce:

1. Create a new post
2. Click "Add Media" and insert an image -- under "ATTACHMENT DISPLAY SETTINGS" make sure the image will have a link of some sort.
3. Once inserted to the post, click the image once to select it.
4. Click "Insert/Edit link" button in TinyMCE toolbar.
5. Type or paste a URL, hit Enter and click "Update"
6. Watch image disappear and be replaced by the bare URL.

[azaozz]

Caused by using the URL when link text is empty. In 33293.patch: use the URL only when the link text field is used.

[iseulde]

Looks good.

[helen]

Looks good.

[markjaquith]

In 33591:

Only use a bare URL when the link text field is used.

Fixes bug that would remove images on edit, in some circumstances.

fixes #33293
props azaozz