WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#33310 closed defect (bug) (fixed)

Error message not shown for nickname when user profile is updated

Reported by: prasad-nevase Owned by: johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2.4
Component: Users Keywords: has-patch
Focuses: administration Cc:

Description

The 'nickname' field is marked as 'required'. But when the profile is updated by keeping 'nickname' empty its replaced by username value and error message is not shown. Ideally it should show the error message like it does for email field. The attached patch handles this and shows error message same as how WordPress shows error message for 'email' field.

Attachments (2)

0001-Updated-user.php-Showed-validation-error-if-requried.patch (4.2 KB) - added by prasad-nevase 6 years ago.
Handled validation error for empty 'Nickname' field under user profile
33310.diff (674 bytes) - added by metodiew 6 years ago.

Download all attachments as: .zip

Change History (8)

@prasad-nevase
6 years ago

Handled validation error for empty 'Nickname' field under user profile

#1 follow-up: @prasad-nevase
6 years ago

  • Keywords has-patch added

Hi Team, Just checking in if there is any update.

@metodiew
6 years ago

#2 in reply to: ↑ 1 @metodiew
6 years ago

Replying to prasad-nevase:

Hi Team, Just checking in if there is any update.

In your patch you've deleted wp-config-sample.php file.

I've updated your patch with a few minor changes

#3 @prasad-nevase
6 years ago

Thanks @metodiew for correcting that ;-)

#4 @prasad-nevase
6 years ago

Just checking if this is still being reviewed?

#5 @johnbillion
6 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Owner set to johnbillion
  • Status changed from new to reviewing

#6 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 34505:

Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it.

Fixes #33310
Props prasad-nevase, metodiew

Note: See TracTickets for help on using tickets.