Opened 10 years ago
Closed 10 years ago
#33325 closed task (blessed) (fixed)
Rearrange function params in Site Icon API
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch |
Focuses: | Cc: |
Description
Having to pass null
as the first parameter if a site icon for the current blog is requested is not very elegant. Let's put it at the end, as it's even more likely that a fallback URL will be passed that a blog id.
Attachments (2)
Change History (12)
This ticket was mentioned in Slack in #core by obenland. View the logs.
10 years ago
#5
@
10 years ago
- Keywords commit removed
We don't use !!
anywhere else in PHP in core - we cast to bool, which is more readable anyway. Since we're in here, let's change that as well.
This ticket was mentioned in Slack in #core by obenland. View the logs.
10 years ago
#9
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
https://travis-ci.org/aaronjorbin/develop.wordpress/builds/74978783
Either the tests also need to be updated, or this had an unintended change.
Note: See
TracTickets for help on using
tickets.
I agree that having to pass
null
as a first parameter is not awesome.+1 for 33325.diff.