#33327 closed defect (bug) (fixed)
Customize: Make Widgets reorder button a button
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Customize | Keywords: | has-patch commit |
Focuses: | ui, accessibility, javascript | Cc: |
Description
Spin off from #33260.
Let's adopt the way Menus handle the reorder button and aggregate styles in customize-controls.css
.
Attachments (4)
Change History (23)
@
9 years ago
This patch also contain "Reorder" link as a button on Widget as well as Menu Customizer.
This ticket was mentioned in Slack in #core by sergey. View the logs.
9 years ago
#8
@
9 years ago
- Version set to 4.3
Refreshed patch. Now the "Reorder" and "Add a Widget" buttons should be functionally the same as the buttons in the Menus. There are some subtle differences in what should be hidden for assistive technologies.
Similar CSS rules are now aggregated and moved to customize-controls.css
.
Simplified the reorder-toggle CSS selectors and rules.
Also, tried to improve some CSS comments as per the handbook CSS coding standards.
Fixed some mixed spaces/tabs.
Would appreciate some testing by the Customizer team :)
This ticket was mentioned in Slack in #core by afercia. View the logs.
9 years ago
#10
follow-up:
↓ 11
@
9 years ago
str_replace()
accepts arrays too:str_replace( array('[', ']' ), array( '-', '' ), $this->id );
esc_attr__( 'Reorder' ),
should get a context, probably the same as<?php _ex( 'Reorder', 'Reorder widgets in Customizer' ); ?>
Otherwise this looks good, grunt precommit
and unit tests are passing.
#11
in reply to:
↑ 10
@
9 years ago
Replying to ocean90:
str_replace()
accepts arrays too
Thanks @ocean90 so it should be changed also in the render()
method I guess, that's the place where I copied and pasted from :D
#12
@
9 years ago
- Keywords commit added
Refreshed patch. Uses arrays for str_replace()
as per @ocean90 suggestion. No need for translation context, the value was wrong in the first place and now is "Reorder widgets" since it should match the initial aria-label
value.
Diff from #33260, props TomHarrigan, afercia