Passwords: Second param of wp_new_user_notification() has been removed

[ocean90]

Originally reported by @Justin_K in ticket:33209:9.

In 4.2 wp_new_user_notification() has a second param $plaintext_pass. If it's not set the user won't get a notification, only the site admin. Now in trunk this param has been removed ([33023]) and the user get's always an email, see ticket:33209:9.

• @jeremyfelt: Maybe repurpose the second param as a flag for sending the notification instead of plain text? If empty don't send.
• This should have a changelog entry.
• @kraft: wp_new_user_notification() is still called with the second param: ​https://github.com/WordPress/WordPress/search?utf8=%E2%9C%93&q=wp_new_user_notification
• (This is a pluggable function.)

[markjaquith]

Simple option — remove the calls.

[ocean90]

untested

[markjaquith]

@ocean90 what's the thought behind 'both' ? Why not just have it be a boolean $email_user flag?

[ocean90]

Replying to markjaquith:

@ocean90 what's the thought behind 'both' ? Why not just have it be a boolean $email_user flag?

Mainly because of this ​http://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#self-explanatory-flag-values-for-function-arguments.

I think we need to take a step back here first:

• Was it a good idea to change a pluggable function like this?
• Shouldn't we introduce a new function instead?
• If not, can we reuse the second param like we want to do or do we have to introduce a third one?
• Or can we change it to $args[] and do a type check?
• ​How are plugins using this function? (Thanks Helen for the list.)

[valendesigns]

@ocean90 what other values would this param except as valid besides both?

[markjaquith]

Replying to valendesigns:

@ocean90 what other values would this param except as valid besides both?

We could add 'admin' as an alias for '' (empty, which will skip the user e-mail). And then for back compat, any other non-empty value means 'both' (as the patch currently does). Doing that now.

[markjaquith]

There.

I'm also not worried about this being pluggable. Things overriding pluggable functions are on their own.

[valendesigns]

We could add 'admin' as an alias for (empty, which will skip the user e-mail). And then for back compat, any other non-empty value means 'both' (as the patch currently does). Doing that now.

Sounds good to me.

I'm also not worried about this being pluggable. Things overriding pluggable functions are on their own.

I agree, you're on your own if you want to override pluggable functions.

[helen]

Looks good to me. That's a hard argument to try to understand without having worked on this at all :)

[ocean90]

Adds changelog entry to wp_new_user_notification()

[obenland]

In 33620:

Passwords: Restore second parameter for wp_new_user_notification().

After [33023] users would always be notified, this restores previous behavior.

Props markjaquith, ocean90.
Fixes #33358.

[ocean90]

Follow-up: #33654