Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33369, comment 9


Ignore:
Timestamp:
08/26/2015 02:51:30 AM (9 years ago)
Author:
TimothyBlynJacobs
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33369, comment 9

    initial v1  
    1 No there is a semantical difference. I'm fine with a plugin filtering the args array. What I'm saying is that I don't think that the original args I pass to the function are a valid source of data for making that decision.
     1No there is a semantic difference. I'm fine with a plugin filtering the args array. What I'm saying is that I don't think that the original args I pass to the function are a valid source of data for making that decision.
    22
    33Also, FWIW, the `get_media_item_args` doesn't seem to pass the original args to a filter anywhere. And the `wp_link_pages` passing the original args array instead of the merged args _seems_ like more of a bug caused by renaming the variable three times :).