Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#33375 closed defect (bug) (fixed)

Menu customizer: Search results section is cut off

Reported by: helen's profile helen Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch commit
Focuses: javascript Cc:

Description

Now that the search results section doesn't behave like the other item sections, it doesn't need to be a part of the section height calculation routine. For reference, this section height manipulation behavior is to avoid double scrollbars where possible on setups that persistently display them.

Attachments (2)

33375.diff (831 bytes) - added by helen 10 years ago.
fixed-with-dev-tools-open.png (117.5 KB) - added by westonruter 10 years ago.

Download all attachments as: .zip

Change History (7)

@helen
10 years ago

#1 @valendesigns
10 years ago

We need to double back on itemSectionHeight in 4.4. However, this will help to mitigate the truncated results in the meantime. It's not pretty, but it works.

+1

#2 @westonruter
10 years ago

33375.diff fixes the truncated search results for me when the dev tools are open.

+1

#3 @markjaquith
10 years ago

Would prefer a solution that was not specific to one thing, but this should do for 4.3.

This ticket was mentioned in Slack in #core by helen. View the logs.


10 years ago

#5 @helen
10 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 33618:

Menu customizer: Ensure the search results section is full height.

fixes #33375.

Note: See TracTickets for help on using tickets.