Asterisk-space sometimes doesn't convert to a bullet

[pento]

If you're typing quickly, sometimes you'll still be holding down the Shift key as you press Space, after pressing *.

This causes the sequence to not convert to a bullet. (The same behaviour occurs for 1) , but not for 1. , because of the lack of Shift in the latter.)

Chrome 44.0.2403.155, OSX.

[azaozz]

We specifically check for modifier keys when pressing the spacebar: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/tinymce/plugins/wptextpattern/plugin.js#L47 and https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/tinymce/plugins/wptextpattern/plugin.js#L41

Perhaps we can only check for Ctrl, Cmd and Alt and allow Shift?

[azaozz]

In 33382.patch: exclude shift when checking for modifier keys when applying the list patterns on pressing the spacebar.

The patterns that activate on enter are still canceled when any modifier is pressed. Currently shift + enter produces a <br> and cancels the replacement.

[pento]

Confirmed that the patch works for me.

+1 for commit.

[obenland]

In 33622:

Editor: Exclude shift from modifier keys when handling spacebar shortcuts.

Patterns that activate on enter are still canceled with any modifier active.

Props azaozz.
Fixes #33382.