Unable to create users in IE8

[pento]

To reproduce:

• Navigate to /user-new.php in IE8 as an admin
• Enter a new username
• Enter a new e-mail address
• Click "Add New User"

This results in the following errors:

ERROR: Please enter your password twice.

ERROR: Please enter the same password in the two password fields.

The same errors occur if you enter a custom password, or a custom weak password.

[pento]

Confirmed that IE9+ works correctly.

[obenland]

Could this be related to #32886? @adamsilverstein, @markjaquith, do you have time to look into it?

[peterwilsoncc]

propertychange (IE8) fires on programatic changes, input does not.

IE8 appears to be looping events and clearing pass2 in the event following the lastpass comment. This causes a password mismatch.

In 33385.1.diff events are fired on the keypress event. It fixes the IE8 password mismatch but introduces a lag/stickiness with the strength meter status not changing immediately.

Needs iteration but I need to sign off now, I am afraid.

[adamsilverstein]

Good catch, I think I understand what was happening here with 'propertychange' which we were using to capture input in ie8.

I tried your patch in ie and and the only issue I still see is the delay in updating the password strength meter you mentioned.

Changing the method from keypress to keyup seems to have alleviated that to some degree, I'm still seeing an empty strength meter if i clear the password field in ie. I'm going to keep digging here to see if I can refine further.

Replying to peterwilsoncc:

propertychange (IE8) fires on programatic changes, input does not.

IE8 appears to be looping events and clearing pass2 in the event following the lastpass comment. This causes a password mismatch.

In 33385.1.diff events are fired on the keypress event. It fixes the IE8 password mismatch but introduces a lag/stickiness with the strength meter status not changing immediately.

Needs iteration but I need to sign off now, I am afraid.

[adamsilverstein]

try #2

[adamsilverstein]

In 33385.2.diff​:

• Bind to keyup event, verified fires correctly across browsers (unlike keypress, fires after input value changes)
• Added the ie8 equivalent css filter matching our opacity settings for the password strength meter.

Note: Because the password meter uses inline styles overriding the display attribute, we are using opacity here to hide the password meter when the password field is blank. This doesn't work in ie8 where opacity isn't fully supported - so you just get a blank box for the password meter. My patch includes a css filter that works in ie8, tested and it works correctly. An untested solution would involve a wrapper element that we could show/hide, not certain would even work though. Another option would be to leave the box as is for ie8, it looks like this:

[adamsilverstein]

Note: also tested with LastPass, verified working correctly.

[adamsilverstein]

js only version of patch

[adamsilverstein]

33385.4.diff​:

• Also address an issue with the cursor jumping to the end of the field when you edit the plaintext password.

[wonderboymusic]

.4.diff looks fine but $('#pass2').on( ... doesn't have to change - for the sake of fixing the ticket, who cares, but it general...

[azaozz]

Looks good here too.

Yeah, $pass2 = $('#pass2').on( ... doesn't need to change, just a bit better readability :)

[obenland]

In 33625:

Passwords: Use keyup event to prevent IE8's misinterpretation of propertychange.

Props adamsilverstein, peterwilsoncc.
Fixes #33385.

[magicroundabout]

This breaks pasting functionality in some other places. You undid #31226. I've raised #33601 about not being able to paste a password into the field in iOS.