tinymce plugin wplink throw js TypeError: editor.wp undefined

[hauvong]

When TinyMCE initialize with plugin wplink enable but not wordpress, the wplink js throw TypeError: editor.wp undefined

To reproduce, initialize a new TinyMCE editor with wplink plugins enable.

tinyMCE.init({
	plugins: "wplink"
});
tinyMCE.execCommand( 'mceAddEditor', true, "textarea" )

To fix, the js should check for wp object exist before calling the function:

editor.on( 'preinit', function() {
	// editor may not have wp object if tinymce wordpress plugin isn't loaded.
	if ( editor.wp && editor.wp._createToolbar ) {
		toolbar = editor.wp._createToolbar( [
			'wp_link_preview',
			'wp_link_edit',
			'wp_link_remove'
		], true );
	}
} );

The patch file is attached.

[hauvong]

fix exception TypeError: editor.wp undefined

[helen]

Does wplink work without the wordpress plugin?

[hauvong]

Replying to helen:

Does wplink work without the wordpress plugin?

Yes, wplink work without the wordpress plugin and there is no error prior to r32902, #32604

[LumberHack]

Tested the fix suggested by @hauvong and it works.

[azaozz]

In 33728:

TinyMCE: ensure the wordpress plugin is loaded before calling _createToolbar().
Props hauvong, azaozz. Fixes #33393.

[azaozz]

Reopen for 4.3 consideration.

[LumberHack]

Replying to azaozz:

Reopen for 4.3.

Any insights on why this got reopened ?

[azaozz]

Replying to LumberHack:

Disabling the wordpress plugin when using the other custom plugins for TinyMCE is a rare edge case that was fixed in trunk. It affects 4.3 so moved it to the 4.3.1 milestone for consideration.

[azaozz]

In 34032:

TinyMCE: ensure the wordpress plugin is loaded before calling _createToolbar().

Props hauvong, azaozz.
Fixes #33393 for 4.3.