Opened 9 years ago
Closed 9 years ago
#33398 closed defect (bug) (fixed)
Feature detect best event to use on password fields
Reported by: | peterwilsoncc | Owned by: | adamsilverstein |
---|---|---|---|
Milestone: | 4.3.1 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Users | Keywords: | has-patch commit fixed-major |
Focuses: | javascript, administration | Cc: |
Description
Following #33385 the user profile JavaScript uses keyup
events to update the password strength meter and keep the password fields in sync.
Not all input methods update fire the keyup event so we use feature detection to detect the optimal event, I propose:
input
keyup
change
The optimal event to use is subjective and up for discussion.
Attachments (3)
Change History (17)
This ticket was mentioned in Slack in #core by chriscct7. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-passwords by sam. View the logs.
9 years ago
#6
@
9 years ago
- Keywords commit dev-feedback added
- Owner set to adamsilverstein
- Status changed from new to assigned
@petewilsoncc:
This looks great, I like your approach for detecting and using the correct method. I tested your patch and verified that it works and also that it resolves #33601.
33398.diff (sorry for mis-naming):
- Refresh against trunk
- Doc block cleanup, use @link for ticket reference, slight language change
- Remove some extraneous newlines
This ticket was mentioned in Slack in #core-passwords by adamsilverstein. View the logs.
9 years ago
#9
@
9 years ago
- Milestone changed from Awaiting Review to 4.3.1
Let's consider this for 4.3.1 since it appears to be the best way to fix #33601.
First pass in 33398.1.diff, went with
input
for preference,keyup
as fallback.change
as third fallback not needed, it has less support thankeyup