WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#33403 closed defect (bug) (fixed)

Total comment count does not update when adding comment/reply after ajax to reply.

Reported by: justingreerbbi Owned by: wonderboymusic
Milestone: 4.4 Priority: low
Severity: minor Version: 3.1
Component: Comments Keywords: has-patch
Focuses: javascript, administration Cc:

Description

Visit wp-admin/edit-comments.php and click "Reply" on any comment. After submitting the reply the comment list will update but "xx Items" will not.

The total comment could is expected to increment by 1.

Attachments (2)

patch.diff (1.4 KB) - added by justingreerbbi 6 years ago.
Concept Patch
patch.2.diff (3.1 KB) - added by justingreerbbi 6 years ago.
Finalized

Download all attachments as: .zip

Change History (10)

#1 @helen
6 years ago

  • Focuses javascript administration added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Version changed from trunk to 3.1

#2 @rachelbaker
6 years ago

@justingreerbbi would you like to submit a patch for this?

#3 @justingreerbbi
6 years ago

Sure. I will try to get to it this weekend if a viable patch has not been submitted by then.

@justingreerbbi
6 years ago

Concept Patch

#4 @justingreerbbi
6 years ago

Just added patch that adds supplemental.total_items_i18n to the return of replyto-comment action.

@justingreerbbi
6 years ago

Finalized

#5 @justingreerbbi
6 years ago

Should be ready for testing! 0o

#6 @justingreerbbi
6 years ago

  • Keywords has-patch added; needs-patch removed

#7 @wonderboymusic
6 years ago

  • Milestone changed from Future Release to 4.4
  • Owner set to wonderboymusic
  • Status changed from new to assigned

Mountains of churn since this patch was posted. I need to do some surgery in edit-comments.js.

#8 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34517:

Comments List Table JS: move the dynamic count functions into closure scope so that setCommentsList AND commentReply can access them. Update counts when replying inline.

Fixes #33403.

Note: See TracTickets for help on using tickets.