WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#33408 closed defect (bug) (fixed)

Typo in comment in async-upload.php

Reported by: chriscct7 Owned by: chriscct7
Priority: normal Milestone: 4.4
Component: Administration Version: 3.5
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description (last modified by chriscct7)

// title shouldn't ever be empty, but use filename just in cas.e should be // title shouldn't ever be empty, but use filename just in case

Typo made in [22755] in 3.5. #blamenacin

Attachments (3)

33408.patch​ (984 bytes ) - added by chriscct7 11 years ago.
33408.2.patch​ (980 bytes ) - added by chriscct7 11 years ago.
Updated the patch to end in period
33408.3.patch​ (980 bytes ) - added by chriscct7 11 years ago.
and start with capital

Download all attachments as: .zip

Change History (8)

@chriscct7
11 years ago

#1 @chriscct7
11 years ago

  • Owner set to chriscct7
  • Status new → accepted

#2 @chriscct7
11 years ago

  • Description modified (diff)

#3 @netweb
11 years ago

  • Component General → Administration
  • Keywords needs-patch good-first-bug added; has-patch commit removed

The patch should be updated to begin with a capital letter and end with a full stop

  • // Title shouldn't ever be empty, but use filename just in case.

​https://make.w.org/core/handbook/best-practices/inline-documentation-standards/php/#5-1-single-line-comments

@chriscct7
11 years ago

Updated the patch to end in period

@chriscct7
11 years ago

and start with capital

#4 @chriscct7
11 years ago

  • Keywords has-patch commit added; needs-patch good-first-bug removed

Done

#5 @wonderboymusic
11 years ago

  • Resolution → fixed
  • Status accepted → closed

In 33640:

Correct punctuation/case for inline comment in async-upload.php

Props chriscct7.
Fixes #33408.

Note: See TracTickets for help on using tickets.