Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #33413, comment 129


Ignore:
Timestamp:
11/24/2015 01:54:23 PM (9 years ago)
Author:
nerrad
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33413, comment 129

    v1 v2  
    1 The definition of `_doing_it_wrong()` in this case can definitely be argued.  However my concern is that this is such a severe breaking change that regardless of whether our code is wrong, the fact that this is such a severe breaking issue means that we're putting WordPress users in the middle of this.  They'll update to WordPress 4.4 and will immediately get a broken admin.
     1The definition of `_doing_it_wrong()` in this case can definitely be argued.  However my concern is that this is such a severe breaking change that regardless of whether the code I have is wrong, we're putting WordPress users in the middle of this.  They'll update to WordPress 4.4 and will immediately get a broken admin.  I '''hope''' I'm the only one doing things wrong in a plugin, but it could be a nightmare if there are others out there doing something similar.
    22
    33At the very least, please DON'T release this so late in this dev cycle.  It would be a totally different story if this breaking change had been added in the beginning of the cycle, with the arguments given for why its needed, and then we (and possibly others) would have time to fix our wrong code and get releases out to users.