#33429 closed defect (bug) (fixed)
Fix Period Position in wp-admin/about.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3.1 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Text Changes | Keywords: | needs-refresh dev-feedback |
Focuses: | administration | Cc: |
Description
wp-admin/about.php#L89 is hard to translate. (at least, in Japanese)
Attachments (3)
Change History (13)
#1
@
10 years ago
- Component changed from Help/About to Text Changes
- Focuses administration added
- Keywords has-patch commit added
- Milestone changed from Awaiting Review to 4.3.1
- Owner set to chriscct7
- Status changed from new to accepted
Refreshed the patch to go from the proper directory.
#2
follow-up:
↓ 4
@
10 years ago
In general, we don't like to add new strings in point releases, and this string is going to change in 4.4.
I'm quite tempted to suggest we simply remove the period from the placeholder and skip the period in the string, or, simply suffixing the period outside of the translation.
33429.patch isn't the same as 33429.diff - the latter moves the period from the placeholder to the string, the former misses removing it from the placeholder.
#3
@
10 years ago
- Keywords needs-refresh added; has-patch commit removed
Indeed it seems the period is missing. I'll get that refreshed
#4
in reply to:
↑ 2
;
follow-up:
↓ 5
@
10 years ago
Replying to dd32:
I'm quite tempted to suggest we simply remove the period from the placeholder and skip the period in the string, or, simply suffixing the period outside of the translation.
33429.2.diff implements this, no string change, and suffixes the period even if the placeholders have changed in their orders.
This assumes all languages would have a period to end a sentence.
Looking at existing translations, the following do NOT use a ending period (or it's translation errors)
- Thai, Armenian, Japanese, Bengali, Chinese (Taiwan), Dzongkha
The following DO use one:
- Swedish, English (Australia), English (Canada), Hebrew, Romanian, German, German (Formal), Finnish, Dutch, Welsh, Greek, Polish, French, Italian, Catalan, Basque, Indonesian, Spanish, Galician, Bosnian, Esperanto, Slovak, Arabic, Korean, Turkish, Serbian, Norwegian (Bokmål), Norwegian (Nynorsk), Bulgarian, Lithuanian, Croatian, English (UK), English (New Zealand), Icelandic, Brazilian Portuguese, Hungarian, Portuguese, Albanian, Spanish (Mexico), Danish, Macedonian, Ukrainian, Russian, Peruvian Spanish
@ocean90 What's your thoughts here? Should we just change the string?
#5
in reply to:
↑ 4
@
10 years ago
Replying to dd32:
@ocean90 What's your thoughts here? Should we just change the string?
The about page is one of the rarely visited screens. I wouldn't change it if it's the only string change.
Patch from proper directory