#33431 closed defect (bug) (fixed)
"(Currently set to: %s)" string needs context
| Reported by: | SergeyBiryukov | Owned by: | ocean90 |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Customize | Version: | 4.3 |
| Severity: | normal | Keywords: | good-first-bug has-patch |
| Cc: | Focuses: |
Description
On the old Menus screen, the string is used for menu locations, and %s is a menu name.
In the Customizer, the same string is used for menus, and %s is a location slug.
On a related note, "(Current: %s)" is missing a translator comment for the placeholder (%s is a menu name).
Attachments (2)
Change History (14)
#3
@
11 years ago
- Keywords has-patch added; needs-patch removed
Hi SergeyBiryukov,
If I understood the bug correctly, the context is showing "Current Menu Location" but %s prints Menu name in Customizer.
I've updated the Context. Let me know if "Current menu name" is fine or "Current menu" is correct.
Thanks
Pranav Shah
#4
@
11 years ago
@SergeyBiryukov: We are missing context for (Currently set to: %s), but on the other hand we have very similar string (Current: %s) for menu name. What about merging them? I do not see a difference, there is only "set to" part added?
#7
follow-up:
↓ 12
@
11 years ago
I think in the Customizer we should show the name too, not the slug.
#9
@
11 years ago
@ocean90,
Attached is a patch, and here is a GitHub PR with the same edits.
This adds translator information for the menu location.
In data passed to a JavaScript file, it adds translator context after (Currently set to: %s).
And in the Customizer nav menu control, it adds a translator comment to indicate the menu name.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Updated Translation Context