PemFTP uses the ereg extension, which PHP7 removed

[dd32]

We include PemFTP which is a pure-php implementation of FTP for usage when the PHP FTP Extension is unavailable.

We should convert PemFTP from using the ereg set of functions, to using PCRE (preg_*), for both PHP7 compatibility and to remove the PHP Deprecated notices in PHP 5.3+.

It looks like the work done in the below GitHub repo is what's needed:
​https://github.com/yama/PemFTP

I believe the PemFTP library is unmaintained upstream, and we already have a number of customisations.

[enshrined]

ereg to preg

[enshrined]

The attached patch is based upon the changes made in the linked repo. Tests seem to pass with it but I couldn't find the specific tests to run on their own.

[dd32]

Looks like glob_regexp() probably needs a preg_quote(), some of the others may need it too if they've got data passed in.

As for tests, AFAIK there exist no tests for this section of code (either by us, or others), and due to the complexity of adding them, it's not going to be realistic to add them either.

[enshrined]

Added preg_quote

[enshrined]

33432.2.diff has the preg_quote added.

I couldn't see anywhere else in the 3 changed files that has regex data passed in to a preg_ function so for now it's just that one added.

[dd32]

In 34281:

Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).

Props enshrined, aaroncampbell
Fixes #16026, #33432

[dd32]

During testing I had to rewrite some of the expressions to match properly in PCRE, line-endings caused problems, it seems to be working for me though.

[dd32]

In 34282:

Updates: FTP: Add a missing PCRE modifer in [34281].

See #16026, #33432x