#33450 closed enhancement (fixed)
Clicking `Generate Password` after `Cancel` should generate a new password
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.4 | Priority: | normal |
| Severity: | normal | Version: | 4.3 |
| Component: | Users | Keywords: | has-patch |
| Focuses: | ui, administration | Cc: |
Description
This issue was brought to my attention by @TheLastCicada.
On screens with the new password generation feature, we offer users a button to Cancel the generate password action (see #33079). If the user clicks Cancel (say for example they don't like the generated password), then decides the click Generate Password again, the field shows the same password as before.
A nice enhancement here would be to regenerate the password each time the user clicked Cancel and then clicked Generate Password again.
Screencast of issue: http://cl.ly/image/39050z0S1c1u
Attachments (2)
Change History (15)
This ticket was mentioned in Slack in #core-passwords by sam. View the logs.
10 years ago
#6
@
10 years ago
- Keywords commit added; dev-feedback removed
- Refresh against trunk.
I verified that the ajax callback is only available to logged in users - hitting the endpoint after logout in a different tab gave me a '0' result. This makes sense because the callback action is added to $core_actions_post which results in ajax endpoints without the nopriv_ variation required for privileged users to access.
This ticket was mentioned in Slack in #core-passwords by adamsilverstein. View the logs.
10 years ago
This ticket was mentioned in Slack in #core-passwords by ocean90. View the logs.
10 years ago
#9
follow-up:
↓ 10
@
10 years ago
- Keywords commit removed
- Milestone changed from 4.3.1 to 4.4
- The summary for
wp_ajax_generate_password()should be something like "AJAX handler for generating a password" - Since
wp-utilsis already a dependency ofuser-profilewe can usewp.ajax()here.
Changing milestone because this is an enhancement.
#10
in reply to:
↑ 9
@
10 years ago
Thanks for the feedback, I will refresh the patch.
Replying to ocean90:
- The summary for
wp_ajax_generate_password()should be something like "AJAX handler for generating a password"- Since
wp-utilsis already a dependency ofuser-profilewe can usewp.ajax()here.Changing milestone because this is an enhancement.
33450.diff:
Proposed fix, adds ajax callback to regenerate password, fires when user clicks
Cancel, in preparation for next 'Generate PasswordScreencast after patch: http://cl.ly/image/45253H0W0Y2H