Comments for WordPress 4.3 to be default "off" for pages but 1 remains

[asilver]

Hi

With the 4.3 release, Comments are supposed to be default "off" on pages. In testing I found the Sample-Page isn't set correctly, with comments "on" as default. This could be confusing to new users to WordPress.

I took the 4.3 zip from .org, not an install from a hosting company auto installer.

[swissspidy]

Thanks for your report, asilver, and welcome to Trac!

I can confirm this. comment_status isn't set when creating the page in wp_install_defaults() because it uses $wpdb->insert() directly. get_default_comment_status() should be used here.

I think this bug is worth fixing as part of 4.3.1 for the reason mentioned above.

[macmanx]

creates sample page with comments switched off on install

[macmanx]

Uploaded patch 33490.diff which will create the sample page with comments off on install.

[kraftbj]

Confirmed 33490.diff resolves. New install's Sample Page is 100% less open for comments.

[wonderboymusic]

In 33693:

When createing "Sample Page" on install, comments should be closed.

Props macmanx.
Fixes #33490.

[asilver]

using the function which returns the globally default comment status instead of just using closed

[kraftbj]

@asilver - you'll need to use the post type arg, e.g. get_default_comment_status( 'page' ); Otherwise, it'll default to 'post' (the default), which would set it as open.

[asilver]

@kraftbj -

gotcha and thanks.
Learning!

[asilver]

Updated from v2 with correct arg

[asilver]

V4 has fixed quotes. Pressed enter to quickly.

[netweb]

Thanks @asilver, 33490.4.diff looks good.

[SergeyBiryukov]

I don't see a reason to use get_default_comment_status() here. It's 'closed' for pages by default, and plugins cannot change it during the install, so [33693] seems enough.

[wonderboymusic]

In 33950:

When creating "Sample Page" on install, comments should be closed.

Props macmanx.
Cherry-picks [33693] onto 4.3 branch.
Fixes #33490 for 4.3.