WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33491 closed task (blessed) (fixed)

Scrutinizer in 4.4

Reported by: wonderboymusic Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

Static analysis, uncovers a lot of edge cases

Change History (14)

#1 @wonderboymusic
4 years ago

In 33697:

In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.

See #33491.

#2 @wonderboymusic
4 years ago

In 33699:

In _WP_Editors::editor_settings(), $first_run is unused.

See #33491.

#3 @wonderboymusic
4 years ago

In 33700:

Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double')

See #33491.

#4 @wonderboymusic
4 years ago

In 33701:

In wpdb::get_col_length(), breaks are not necessary when a case returns

See #33491.

#5 @wonderboymusic
4 years ago

In 33734:

foreach is a statement, not a function.

See #33491.

#6 @wonderboymusic
4 years ago

In 33735:

In WP_Users_List_Table::single_row(), $actions is not always set before being used.

See #33491.

#7 @wonderboymusic
4 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned
  • Type changed from defect (bug) to task (blessed)

#8 @wonderboymusic
4 years ago

In 33956:

In wpdb::get_col_length(), the final return false is unreachable since the default switch case returns.

See #33491.

#9 @wonderboymusic
4 years ago

In 33957:

WP_Theme has an ad hoc property in WP_MS_Themes_List_Table, $update. This can be set to a default value on the class, as it's not obtained via __get().

See #33491.

#10 @wonderboymusic
4 years ago

In 33958:

In WP_User, add @property docs for description, first_name, and last_name. user_firstname and user_lastname only exist for back-compat.

See #33491.

#11 @DrewAPicture
4 years ago

In 34236:

Docs: Fix some syntactical issues with the DocBlock for the WP_Theme->update property, introduced in [33957].

Adds an @since.

See #33491. See #32246.

#12 @wonderboymusic
4 years ago

In 34446:

Remove some unused globals and/or their docs.

See ##33491.

#13 @wonderboymusic
4 years ago

In 35013:

Docs: some @global object vernaculars should be converted to the actual object type.

See #33491.

#14 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.