Context Navigation

← Previous Ticket
Next Ticket →

#33491 closed task (blessed) (fixed)

Scrutinizer in 4.4

Reported by:	wonderboymusic	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.4
Component:	General	Version:	4.4
Severity:	normal	Keywords:
Cc:		Focuses:

Description

Static analysis, uncovers a lot of edge cases

Change History (14)

#1 @wonderboymusic
11 years ago

In 33697:

In wp_ajax_add_meta(), do not juggle the value of $_POST and alter it directly. This was done so that edit_post() could pull $_POST out of the air by-reference and alter it (equally as bad). edit_post() accepts a $post_data array. Do that instead.

See #33491.

#2 @wonderboymusic
11 years ago

In 33699:

In _WP_Editors::editor_settings(), $first_run is unused.

See #33491.

#3 @wonderboymusic
11 years ago

In 33700:

Doc block for_wp_specialchars: $quote_style can also be string ('single' or 'double')

See #33491.

#4 @wonderboymusic
11 years ago

In 33701:

In wpdb::get_col_length(), breaks are not necessary when a case returns

See #33491.

#5 @wonderboymusic
11 years ago

In 33734:

foreach is a statement, not a function.

See #33491.

#6 @wonderboymusic
11 years ago

In 33735:

In WP_Users_List_Table::single_row(), $actions is not always set before being used.

See #33491.

#7 @wonderboymusic
11 years ago

Owner set to wonderboymusic
Status new → assigned
Type defect (bug) → task (blessed)

#8 @wonderboymusic
11 years ago

In 33956:

In wpdb::get_col_length(), the final return false is unreachable since the default switch case returns.

See #33491.

#9 @wonderboymusic
11 years ago

In 33957:

WP_Theme has an ad hoc property in WP_MS_Themes_List_Table, $update. This can be set to a default value on the class, as it's not obtained via __get().

See #33491.