WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#33494 closed defect (bug) (duplicate)

Empty panels are revealed after a preview pane refresh

Reported by: coreymckrill4ttf Owned by: westonruter
Milestone: Priority: normal
Severity: normal Version: 4.1
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Description

Registered panels that don't have any sections in them are hidden. However, after updating a theme option that triggers a full preview pane refresh, those panels appear in the list. Clicking on them reveals that they are empty.

Tested in Twenty Fifteen by adding this code to the top of the twentyfifteen_customize_register function:

$wp_customize->add_panel( 'testheader', array( 'title' => 'Header' ) );

Attachments (2)

Change History (13)

#1 @westonruter
5 years ago

  • Focuses javascript added
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 4.3.1
  • Owner set to westonruter
  • Status changed from new to accepted
  • Version changed from 4.3 to 4.1

@coreymckrill4ttf Thanks for the report. I can confirm this is an issue.

It looks like the problem is just that the contextually-active state of the panel (or section) is not being checked in all scenarios where the panel's active state is being updated. So 33494.diff moves the check further down the stack so contextually-inactive panels (i.e. those that have no sections) will not inadvertently start to show up.

Please test.

#2 @coreymckrill4ttf
5 years ago

@westonruter Yep, the most recent diff seems to fix it!

#3 @westonruter
5 years ago

  • Keywords needs-testing removed

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


5 years ago

#5 follow-up: @progmastery
5 years ago

Is this issue related with #33538 ?

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#6 in reply to: ↑ 5 @westonruter
5 years ago

Replying to progmastery:

Is this issue related with
https://core.trac.wordpress.org/ticket/33538 ?

Actually, #33428.

#7 @westonruter
5 years ago

  • Keywords reporter-feedback added

@coreymckrill4ttf Please confirm that the fix committed in #33428 [33754] does actually resolve the issue reported here as well.

#8 @coreymckrill4ttf
5 years ago

Confirmed!

#9 @westonruter
5 years ago

  • Keywords reporter-feedback removed
  • Resolution set to fixed
  • Status changed from accepted to closed

Closing since issue fixed in #33428 [33754].

#10 @westonruter
5 years ago

  • Milestone 4.3.1 deleted
  • Resolution changed from fixed to duplicate

Duplicate of #33428.

#11 @westonruter
5 years ago

#33538 was marked as a duplicate.

Note: See TracTickets for help on using tickets.