Empty panels are revealed after a preview pane refresh

[coreymckrill4ttf]

Registered panels that don't have any sections in them are hidden. However, after updating a theme option that triggers a full preview pane refresh, those panels appear in the list. Clicking on them reveals that they are empty.

Tested in Twenty Fifteen by adding this code to the top of the twentyfifteen_customize_register function:

$wp_customize->add_panel( 'testheader', array( 'title' => 'Header' ) );

[westonruter]

​https://github.com/xwp/wordpress-develop/pull/114

[westonruter]

@coreymckrill4ttf Thanks for the report. I can confirm this is an issue.

It looks like the problem is just that the contextually-active state of the panel (or section) is not being checked in all scenarios where the panel's active state is being updated. So 33494.diff​ moves the check further down the stack so contextually-inactive panels (i.e. those that have no sections) will not inadvertently start to show up.

Please test.

[westonruter]

Additional change: ​https://github.com/xwp/wordpress-develop/commit/54e8da6695f20e04a050b40923adf734d25a7a09

[coreymckrill4ttf]

@westonruter Yep, the most recent diff seems to fix it!

[progmastery]

Is this issue related with
https://core.trac.wordpress.org/ticket/33538 ?

[westonruter]

Replying to progmastery:

Is this issue related with
https://core.trac.wordpress.org/ticket/33538 ?

Actually, #33428.

[westonruter]

@coreymckrill4ttf Please confirm that the fix committed in #33428 [33754] does actually resolve the issue reported here as well.

[coreymckrill4ttf]

Confirmed!

[westonruter]

Closing since issue fixed in #33428 [33754].

[westonruter]

Duplicate of #33428.

[westonruter]

#33538 was marked as a duplicate.