Opened 8 years ago
Closed 8 years ago
#33514 closed defect (bug) (fixed)
Update x Upgrade database
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Text Changes | Keywords: | |
Focuses: | multisite | Cc: |
Description
We are updating database for single site, but upgrading for multisite. We can merge it and remove 2 similar strings. We can still "Upgrade Network", but database should be "updated".
See attached patch.
Attachments (2)
Change History (10)
#1
@
8 years ago
- Focuses multisite added
- Milestone changed from Awaiting Review to 4.4
- Version trunk deleted
#2
@
8 years ago
The verbiage we mostly use is, Update
means a filesystem change, Upgrade
means a database change.
Of course, it's actually WP_Upgrader
which does filesystem changes :) but upgrade.php
contains database-upgrade routines.
#3
@
8 years ago
OK, so I can reverse it :-) Upgrade
for database and Update
for filesystem seems reasonable, so we can change 2 single site strings (we are also within upgrade.php
file). I only wanted to remove 2 similar strings with different words (found during translation)...
This ticket was mentioned in Slack in #core by sergey. View the logs.
8 years ago
#7
@
8 years ago
Previously in #24931:
nacin: not sure about the second one - while we try to use "update" to mean one thing and "upgrade" to mean the other, the important part is "update"
nacin: the second part ("upgrade" meaning a DB upgrade) has always kind of been a corollary, but not necessarily set in stone
nacin: in this case we're linking it specifically to the word "database"
nacin: SergeyBiryukov: talked to jenmylo. "Update" should be preferred wherever it makes sense, including here.
nacin: I don't necessarily think that runs afoul of r23619.
33514.2.patch merges the strings and keeps "database update" on both screens.
I'm cool with making the text change, but I'm wondering about the strings around it.
Should "we need to individually upgrade the sites in your network" be changed to say "update", too?
"Upgrade" in "Upgrade Network" then feels out of place. The equivalent button in single site says "Update WordPress Database".