WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33529 closed defect (bug) (wontfix)

IXR_Client overrides and sets incorrect HTTPS default port

Reported by: beaucollins Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: close
Focuses: Cc:
PR Number:

Description

IXR_Client will attempt to parse the correct parameters from the $server argument when $path is not provided.

In cases where the port is not provided within the url (e.g. "https://example.com:443/") it will always default to port 80 no matter which scheme is used.

If no port is in the URL it should default to the correct port for the given scheme.

Attachments (1)

changeset_123058.diff (978 bytes) - added by beaucollins 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @dd32
4 years ago

Realistically clients should be extending WP_HTTP_IXR_Client instead - it uses the HTTP API rather than direct fsockopen calls, and doesn't suffer from this problem.

#2 @dd32
4 years ago

  • Keywords close added

Upon further inspection, it seems that IXR_Client doesn't even support SSL anyway.. I'm going to recommend we just leave it be, and leave those who run into problems with the simple answer of Use WP_HTTP_IXR_Client instead.

#3 @johnbillion
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.