WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33552, comment 1


Ignore:
Timestamp:
08/26/2015 06:54:46 AM (5 years ago)
Author:
DrewAPicture
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33552, comment 1

    initial v1  
    11@DrewAPicture [https://core.trac.wordpress.org/ticket/33411#comment:9 commented on 33411]:
    22
    3 Very interesting. I wonder what if any potential downsides there might be in placing such a general hook this high up in the stack.
    4 
    5 I'd almost be tempted use a dynamic hook with a whitelist based on the `nav_menus` and `widgets` properties to sort of lock it down to this specific context.
    6 
    7 The whitelist could be expanded in the future without opening the door wide to the scenario that any general-purpose hook brings: having to support any number of unexpected use-cases down the road.
     3> Very interesting. I wonder what if any potential downsides there might be in placing such a general hook this high up in the stack.
     4>
     5> I'd almost be tempted use a dynamic hook with a whitelist based on the `nav_menus` and `widgets` properties to sort of lock it down to this specific context.
     6>
     7> The whitelist could be expanded in the future without opening the door wide to the scenario that any general-purpose hook brings: having to support any number of unexpected use-cases down the road.