Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#33560 closed defect (bug) (fixed)

#a11y-headings - Themes page heading fixes

Reported by: Cheffheid Owned by: SergeyBiryukov
Priority: normal Milestone: 4.4
Component: Administration Version: 4.3
Severity: normal Keywords: has-patch
Cc: Focuses: accessibility

Description (last modified by joedolson)

Each theme's name (in both the list and the theme details dialog) is an H3 that needs to be changed to an H2.

The theme details also list the theme's author with an H4, which needs to be bumped up to an H3.

Additionally, the "Update Available" text is also an H4. With the theme's author being changed to H3 already it can probably remain that way if there's any value to be had in keeping it a heading.

Like with the other heading tickets, ensure that the design doesn't change and ensure everything keeps working like it was before.

#a11y-headings

Attachments (2)

33560.patch​ (3.5 KB ) - added by joehills 11 years ago.
Changes the heading tags for theme name and author, 2 minor css changes to preserve styles
33560.2.patch​ (3.5 KB ) - added by joehills 11 years ago.
Same code changes, but generated patch form WordPress root instead of trunk. Apologies, first time committer.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in ​Slack in #accessibility by cheffheid. ​View the logs.


11 years ago

#2 @joedolson
11 years ago

  • Description modified (diff)

@joehills
11 years ago

Changes the heading tags for theme name and author, 2 minor css changes to preserve styles

@joehills
11 years ago

Same code changes, but generated patch form WordPress root instead of trunk. Apologies, first time committer.

#3 @joehills
11 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #accessibility by joehills. ​View the logs.


11 years ago

#5 @Cheffheid
11 years ago

@joehills Looking good, thank you!

There's one more heading that would need to get changed (and I missed it on my initial description) and it's for the "Add New Theme" link block. Once that's done it should be good to go as far as I'm concerned.

#6 @SergeyBiryukov
11 years ago

  • Milestone Awaiting Review → 4.4

#7 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 33820:

Bump H3 headings to H2 on Themes screen for better accessibility.

props joehills.
fixes #33560.

Note: See TracTickets for help on using tickets.