WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33575 closed defect (bug) (fixed)

Text getting cut in customizer panel title

Reported by: umesh.nevase Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-patch
Focuses: ui, administration Cc:
PR Number:

Description

The text getting cut if there is g or y letter in panel title. If we increase line height it will solve the problem. I've checked on both Windows and Ubuntu Firefox and Chrome browsers.

Attachments (7)

wordpress-customizer-widget.png (21.1 KB) - added by umesh.nevase 4 years ago.
customize-controls-rtl.diff (597 bytes) - added by umesh.nevase 4 years ago.
patch. Fixed the issue.
33575.diff (597 bytes) - added by umesh.nevase 4 years ago.
Fixed the issue
Customizer_panel.png (21.2 KB) - added by umesh.nevase 4 years ago.
The 'g' letter is cut from bottom
33575.2.diff (1.0 KB) - added by umesh.nevase 4 years ago.
Checked on windows Firefox, Chrome, Safari and Ubuntu's firefox, Chrome, New patch is working file on latest browsers.
33575.3.diff (1.0 KB) - added by umesh.nevase 4 years ago.
working patch
33575.4.diff (1.1 KB) - added by DrewAPicture 4 years ago.

Download all attachments as: .zip

Change History (17)

#1 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Customize
  • Focuses accessibility removed

@umesh.nevase
4 years ago

patch. Fixed the issue.

@umesh.nevase
4 years ago

Fixed the issue

@umesh.nevase
4 years ago

The 'g' letter is cut from bottom

#2 @westonruter
4 years ago

  • Keywords reporter-feedback added

@umesh.nevase I've never seen this issue before myself, personally. I did start to see the “g” being cut off at the bottom when I zoomed out in Chrome. Are the fonts on your system adjusted to be different than the defaults, perhaps? Are you at a non-default zoom level?

#3 @umesh.nevase
4 years ago

@westonruter, I've checked at default zoom level on Windows8 with latetst firefox and Ubuntu 14.04 LTS ( Firefox 40.0 ). Font family is 'Open Sans'. The 'g' is getting cut off on firefox.

#4 @umesh.nevase
4 years ago

  • Keywords has-patch added

#5 @SergeyBiryukov
4 years ago

  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.4

Confirmed in Firefox on Windows 7.

@umesh.nevase
4 years ago

Checked on windows Firefox, Chrome, Safari and Ubuntu's firefox, Chrome, New patch is working file on latest browsers.

#6 @umesh.nevase
4 years ago

33575.2.diff is working patch file, previous attached patch was not working

@umesh.nevase
4 years ago

working patch

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#8 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#9 @stevehenty
4 years ago

I reproduced this issue in Firefox on Mac - Chrome and Safari were fine. The patch fixed the issue.

@DrewAPicture
4 years ago

#10 @DrewAPicture
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35511:

Customizer: Adjust styles on panel titles to prevent descenders – such as with the letters g, j, p, q, or y – from getting cut off in some browsers.

Props umeshnevase.
Fixes #33575.

Note: See TracTickets for help on using tickets.