Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#33577 closed defect (bug) (wontfix)

Customizer Help toggle button is not horizontally aligned with panel title

Reported by: umeshnevase's profile umesh.nevase Owned by:
Milestone: Priority: low
Severity: trivial Version: 4.3
Component: Customize Keywords: has-patch
Focuses: ui, administration Cc:

Description

Help toggle button on customizer is horizontally aligned to panel title. I've checked that all other icons are horizontally aligned with text. I've checked on latest Firefox and Chrome.
Go to
Dashboard -> Appearance -> Customize

Attachments (3)

customizer_help_toggle.png (14.2 KB) - added by umesh.nevase 10 years ago.
Image for issue
33577.diff (573 bytes) - added by umesh.nevase 10 years ago.
Patch for the issue
help_toggle_solved.png (23.1 KB) - added by umesh.nevase 10 years ago.
Image for Solved issue

Download all attachments as: .zip

Change History (9)

@umesh.nevase
10 years ago

Image for issue

@umesh.nevase
10 years ago

Patch for the issue

@umesh.nevase
10 years ago

Image for Solved issue

#1 @umesh.nevase
10 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.4
  • Priority changed from normal to low
  • Severity changed from normal to trivial

#3 follow-up: @valendesigns
10 years ago

View Menus in the Customizer, there is another icon that toggles menu options. Does the alignment break with this patch applied?

#4 in reply to: ↑ 3 @umesh.nevase
10 years ago

Replying to valendesigns:

View Menus in the Customizer, there is another icon that toggles menu options. Does the alignment break with this patch applied?

@valendesigns, no it is not affecting the other icons.

#5 @valendesigns
10 years ago

You shouldn't patch customize-controls-rtl.css, it's an auto generated file. Also, the tap target area with the Menus properties icon is to close to make this change and they would be overlapping. Another issue is that FireFox doesn't take the change with grace, the alignment is way off. I don't think this is something we should do.

#6 @helen
10 years ago

  • Milestone 4.4 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The help icon is currently a different size from other circular icons for some reason, which really should be addressed at the Dashicon level. Until then, let's not tinker with this, as it's proven to be very fragile between browsers. See #32733 for more.

Note: See TracTickets for help on using tickets.