Caret icon on widget title does not flip appropriately

[sdavis2702]

On widgets.php, collapsed widgets already positioned in a sidebar area have a downward pointing caret icon. When you expand a widget, the caret switches to pointing up. Cool.

When you go to drag an expanded widget, it collapses automatically and remains collapsed even after it is "dropped." However, once collapsed, the caret continues to point up as if the widget was expanded.

Clicking the now collapsed widget expands it again and from there, the inconsistency is corrected. This patch corrects the caret behavior the moment you start to drag an expanded widget.

Note: There are plenty of sortable elements in core and I searched hard to find other elements that use the .ui-sortable-helper class. The widgets are the only ones I found. If you know of others, please speak up.

[sdavis2702]

At the moment when the "ui-sortable-helper" class is added to the widget element that has an "open" class because it is expanded, I've removed the pre-existing "open" class.

[westonruter]

@sdavis2702: Thanks for the report. However, modifying jQuery UI's sortable.min.js isn't going to be the right approach. Instead, the changes will need to be made to widgets.js and potentially customize-widgets.js.

[sdavis2702]

@westonruter I completely overlooked what file I was editing. Thanks. I'll shift focus to widgets.js. Just so I know how this works, I shouldn't have to do any minimizing on my end right?

[SergeyBiryukov]

Replying to sdavis2702:

Just so I know how this works, I shouldn't have to do any minimizing on my end right?

Yes, minified files should not be patched, our build tools take care of that.

There's a ​SCRIPT_DEBUG constant you can add to your wp-config.php file to use non-minified files.

[sdavis2702]

Thanks, @SergeyBiryukov! Already on it.

[chriscct7]

Possibly related:
#13524

[mindctrl]

What is the desired behavior when dropping an expanded widget? Toggle the caret and keep the widget collapsed, or return the widget to the open state?

[mindctrl]

Toggles the caret closed when dragging

[mindctrl]

Attached patch toggles the caret and keeps the expanded widget closed/hidden when dropped. If we'd like it the other way around, let me know and I'll update the patch.

[sdavis2702]

I believe that's the desired behavior and if it's not, I think it should be.

The patch works perfectly on my end.

[wonderboymusic]

In 34165:

Ensure that widget carets close when dragging an expanded widget.

Props sdavis2702, mindctrl.
Fixes #33578.

[dlh]

#31877 was marked as a duplicate.