Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #33580


Ignore:
Timestamp:
08/28/2015 06:38:59 PM (8 years ago)
Author:
johnbillion
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33580

    • Property Keywords needs-patch needs-testing added
    • Property Version changed from trunk to
  • Ticket #33580 – Description

    initial v1  
    11In wp-tests/tests/phpunit/includes/bootstrap.php there is this line:
     2
     3{{{
    24system( WP_PHP_BINARY . ' ' . escapeshellarg( dirname( __FILE__ ) . '/install.php' ) . ' ' . escapeshellarg( $config_file_path ) . ' ' . $multisite);
     5}}}
    36
    4 To reproduce the bug, make sure xdebug.remote_enable=1and that xdebug is configured to connect back to your ide (xdebug.remote_connect_back=1 xdebug.remote_host=x.x.x.x).
     7To reproduce the bug, make sure `xdebug.remote_enable=1` and that xdebug is configured to connect back to your ide (`xdebug.remote_connect_back=1` `xdebug.remote_host=x.x.x.x`).
    58
    69When this system line is called from phpunit and you have xdebug listening in your IDE (I use PHPStorm), phpunit will hang.
     
    912
    1013To fix this issue, I've made a simple change locally, updating the system call to:
     14
     15{{{
    1116system( WP_PHP_BINARY . ' -d xdebug.remote_enable=0' . escapeshellarg( dirname( __FILE__ ) . '/install.php' ) . ' ' . escapeshellarg( $config_file_path ) . ' ' . $multisite);
     17}}}
    1218
    1319This disables xdebug in the process spawned by system(). I can have xdebug enabled and I get no errors and set breakpoints in my tests.
    1420
    1521Should I make a patch with my fix or does someone have a better way?
    16 
    17 
    18