Opened 9 years ago
Closed 9 years ago
#33595 closed defect (bug) (fixed)
No red links for the user's archived sites anymore.
Reported by: | programmin | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Networks and Sites | Keywords: | good-first-bug has-patch |
Focuses: | ui, multisite | Cc: |
Description
In previous versions of Wordpress (eg 4.1) when you searched for a user under multisite dashboard's Users panel, the listing of the user's sites to the right had a red rectangle where you can edit a deleted/archived site. In 4.3 you no longer see a red block on that link, and it's a bit annoying to have to go through each and see what site isn't the archived one.
Attachments (4)
Change History (14)
#1
@
9 years ago
- Keywords good-first-bug added
- Milestone changed from Awaiting Review to 4.4
- Version changed from 4.3 to 4.2
#3
follow-up:
↓ 4
@
9 years ago
Reproduction path:
- Create some sites in Multisite
- Create users in this site
- Archive the site from multisite panel
- Go to Multisite/Users
- Find a user of a deleted site, go to 'sites' column and 'hover' a site previously archived
- 'View' link should have a red background
What have I found:
- As @jeremyfelt has pointed out, the element is an A.site-deleted, the style is for TR.site-deleted
- Whole 'list-tables.css' file @jeremyfelt mentioned is not enqueued NOR registered. I am trying to find out why or if it should.
#4
in reply to:
↑ 3
@
9 years ago
Replying to artpi:
- Whole 'list-tables.css' file @jeremyfelt mentioned is not enqueued NOR registered. I am trying to find out why or if it should.
The vast majority of sites use production scripts and styles, which are concatenated. Our wp-admin.css
has individual files for development - you can set SCRIPT_DEBUG
to true to see them in use.
#5
@
9 years ago
- Keywords has-patch added; needs-patch removed
I see no reason why the more specific selector (e.g. .wp-list-table tr.site-deleted instead of .wp-list-table .site-deleted) was created in [31181]. I've removed tr from the selector and it fixes the problem. No side effects as far as I can see.
#6
@
9 years ago
- Owner set to obenland
- Resolution set to fixed
- Status changed from new to closed
In 34356:
#8
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Removing the tr.
specificity allows another style to override .site-deleted
(and others) on even numbered rows. This was originally reported in #34630.
We'll need to account for the specific and more generic versions.
#9
@
9 years ago
33595.diff re-applies specific rules for table rows and keeps the more generic .site-*
rules for other elements.
It looks like [31181] added specificity for the background color applied to
.site-archived
, etc... which removed the style from other things classified that way.Looking at the full changeset, I don't see anything that prevents us from removing the
tr
specification on the.wp-list-table tr.site-*
CSS rules.