WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#33595 closed defect (bug) (fixed)

No red links for the user's archived sites anymore.

Reported by: programmin Owned by: obenland
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: ui, multisite Cc:

Description

In previous versions of Wordpress (eg 4.1) when you searched for a user under multisite dashboard's Users panel, the listing of the user's sites to the right had a red rectangle where you can edit a deleted/archived site. In 4.3 you no longer see a red block on that link, and it's a bit annoying to have to go through each and see what site isn't the archived one.

Attachments (4)

tr.diff (1.3 KB) - added by psoluch 4 years ago.
Users_‹_Network_Admin__die4punkte_Sites_—_WordPress.png (21.9 KB) - added by psoluch 4 years ago.
BEFORE Screenshot
Users_‹_Network_Admin__die4punkte_Sites_—_WordPress.2.png (22.7 KB) - added by psoluch 4 years ago.
33595.diff (784 bytes) - added by jeremyfelt 4 years ago.

Download all attachments as: .zip

Change History (14)

#1 @jeremyfelt
4 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 4.4
  • Version changed from 4.3 to 4.2

It looks like [31181] added specificity for the background color applied to .site-archived, etc... which removed the style from other things classified that way.

Looking at the full changeset, I don't see anything that prevents us from removing the tr specification on the .wp-list-table tr.site-* CSS rules.

#2 @jeremyfelt
4 years ago

  • Keywords needs-patch added

#3 follow-up: @artpi
4 years ago

Reproduction path:

  • Create some sites in Multisite
  • Create users in this site
  • Archive the site from multisite panel
  • Go to Multisite/Users
  • Find a user of a deleted site, go to 'sites' column and 'hover' a site previously archived
  • 'View' link should have a red background

What have I found:

  • As @jeremyfelt has pointed out, the element is an A.site-deleted, the style is for TR.site-deleted
  • Whole 'list-tables.css' file @jeremyfelt mentioned is not enqueued NOR registered. I am trying to find out why or if it should.

#4 in reply to: ↑ 3 @helen
4 years ago

Replying to artpi:

  • Whole 'list-tables.css' file @jeremyfelt mentioned is not enqueued NOR registered. I am trying to find out why or if it should.

The vast majority of sites use production scripts and styles, which are concatenated. Our wp-admin.css has individual files for development - you can set SCRIPT_DEBUG to true to see them in use.

#5 @psoluch
4 years ago

  • Keywords has-patch added; needs-patch removed

I see no reason why the more specific selector (e.g. .wp-list-table tr.site-deleted instead of .wp-list-table .site-deleted) was created in [31181]. I've removed tr from the selector and it fixes the problem. No side effects as far as I can see.

@psoluch
4 years ago

#6 @obenland
4 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 34356:

Multisite: Make site status classes available to other elements.

Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.

Fixed during WordCamp Switzerland Contributor Day.

Props psoluch.
Fixes #33595.

#7 @jeremyfelt
4 years ago

#34630 was marked as a duplicate.

#8 @jeremyfelt
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Removing the tr. specificity allows another style to override .site-deleted (and others) on even numbered rows. This was originally reported in #34630.

We'll need to account for the specific and more generic versions.

@jeremyfelt
4 years ago

#9 @jeremyfelt
4 years ago

33595.diff re-applies specific rules for table rows and keeps the more generic .site-* rules for other elements.

#10 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 35692:

Multisite: Re-Account for striped table rows with .site-* classes.

[34356] removed the table row specificity on rules for .site-deleted, .site-spammed, .site-archived, and .site-matured so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.

We can account for tr specific and more generic applications of these classes.

Fixes #33595.

Note: See TracTickets for help on using tickets.