#33596 closed defect (bug) (fixed)
Bug in Comment Quick Edit in smaller screen
Reported by: | gyan | Owned by: | helen |
---|---|---|---|
Milestone: | 4.3.1 | Priority: | normal |
Severity: | normal | Version: | 4.3 |
Component: | Comments | Keywords: | has-patch needs-testing has-screenshots |
Focuses: | ui, administration | Cc: |
Description
There is display issue in Comments Quick Edit mode when screen size is less than 782px.
There is no issue if screen size greater than 782px.
I have tested with both Google Chrome and Mozilla Firefox.
I am using Windows 7.
Attachments (10)
Change History (28)
#3
@
9 years ago
- Milestone changed from Awaiting Review to 4.3.1
Introduced in [33016], which changed <tr id="replyrow">
from display: table-cell
to display: block
due to .wp-list-table tr:not(.inline-edit-row) td:not(.check-column)
in line 1750.
I've found a related issue in Comments meta box: .column-author
does not get hidden, leading to duplicate author name, see 33596.comments-meta-box.png.
33596.patch fixes both of these issues, but appears to introduce a new one: if you quick edit one comment in the meta box, others shrink to 50%, see 33596.comments-meta-box-quick-edit.png.
#6
@
9 years ago
I found a way to fix CSS issue for Comments Quick Edit and Reply when screen size is less than 782px.
#replyrow td { display: table-cell; }
#8
@
9 years ago
@SergeyBiryukov maybe this ticket should mention Kindle Fire Silk browser to make it easier to find in ticket searches.
#9
@
9 years ago
The half-width thing in 33596.comments-meta-box-quick-edit.png is because the quick edit/reply row has a colspan of 2 (and I think some other things do, like the undo message) - I don't remember what I did to handle this in other list tables, but that's where to look.
#11
@
9 years ago
- Keywords has-patch needs-testing added; needs-patch removed
33596.3.patch gives input fields more width on narrow screens and updates the colspan
attribute, see [33015] for posts and terms. Since the comment metabox has no table header I'm using c
which holds a comment row.
#14
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Just noticed: edit a Post that already has some comments. The "Add new Comment" will look like this;
This is because the table with comments here has two columns but the colspan
attribute set with JavaScript will be 0. Doesn't happen in Posts that don't have comments yet, since there's no table there.
Minor: in Dashboard > Activity > Comments, the comments list doesn't use a table and #replyrow
is a <div>
; we shouldn't try to set a colspan there, even if at the moment it doesn't break anything.
Comment Quick Edit issue